Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialization option completion.placeholder; change client.snippetSupport: false to drop ( and < #497

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

MaskRay
Copy link
Owner

@MaskRay MaskRay commented Oct 7, 2019

  • client.snippetSupport: false => foo
  • client.snippetSupport: true
    • completion.placeholder: false => foo($1)$0 bar<$1>()$0
    • completion.placeholder: true => foo(${1:int a}, ${2:int b})$0 bar<${1:typename T}>()$0

Note, client.snippetSupport is always false if the client does not support snippets.

Close #412

@MaskRay MaskRay force-pushed the completion branch 5 times, most recently from 9219b8c to e8974ef Compare October 9, 2019 15:13
@MaskRay MaskRay changed the title Drop trailing ( or < from TextEdit.newText if client.snippetSupport is false Add initialization option completion.placeholder; change client.snippetSupport: false to drop ( and < Oct 9, 2019
…etSupport: false to drop ( and <

* client.snippetSupport: false => `foo`
* client.snippetSupport: true
  + completion.placeholder: false => `foo($1)$0` `bar<$1>()$0`
  + completion.placeholder: true => `foo(${1:int a}, ${2:int b})$0` `bar<${1:typename T}>()$0`

Note, client.snippetSupport is always false if the client does not support snippets.

Close #412
@MaskRay MaskRay merged commit 9275aa3 into master Oct 10, 2019
@MaskRay MaskRay deleted the completion branch October 10, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not insert parentheses when completing function
1 participant