Improve completion cache. #521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iensen
force-pushed
the
master
branch
2 times, most recently
from
f4d03ae to
f4e1843
Compare
MaskRay
reviewed
Nov 8, 2019
There was a problem hiding this comment.
Thanks for narrowing down the issue. I didn't even perceive any difference!
I think we can just do:
- return this->path == path && this->position == position;
+ return this->position == position && this->path == path &&
+ this->line.compare(0, position.character, line, 0,
+ position.character) == 0;Just amended that broken commit.
| @@ -176,7 +176,7 @@ template <typename T> struct CompleteConsumerCache { | |||
| Position position) { | |||
| std::lock_guard lock(mutex); | |||
| return this->path == path && this->position == position && | |||
| this->line == line; | |||
| line.substr(0,position.character) == this->line.substr(0, position.character); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this change 1a41d2d made auto-completion for my large projects completely unusable.
My scenario is as follows.
Suppose I have a class variable c, and I want to type c->some_method.
When I type c->, I wait 0.5-1 second until some_method appears. (my idle-delay is set to 0, but it doesn't really matter).
Then, when I type o (the next character), emacs freezes and for 0.5 -1 seconds before it generates new completions request. This happens because it no longer uses the cache and the completions are recomputed again.
This is super inconvenient! Previously, we used to reuse the cache for position c-> and filter it out when the new characters are added.
As far as I understand, my change should fix the bug which the original commit was supposed to fix, and will satisfy the important use case I desribed above (I verified the latter). But I may be misunderstanding the code, let me know.