Resolve "directory" in compile_commands.json in case CWD is not the project root #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @MaskRay won't it be better to change to the root directory when initializing ccls rather than just finding the relative path from root for |
|
ccls supports workspace folders. With workspace folders, you may have several projects. The snippet does not work anyway. |
|
Do you mind if I try doing this enhancement/bug fix? |
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
ee29996 to
feb153a
Compare
…roject root Also delete an unneeded chdir hack. Close #703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also delete an unneeded chdir hack.