Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max David Metelus : Open Pull Request :Work In Progress. #1

Merged
merged 5 commits into from
Jan 15, 2019

Conversation

Mdmetelus
Copy link
Owner

Open Pull Request

@Mdmetelus Mdmetelus requested a review from johnoro January 15, 2019 00:22
Copy link
Collaborator

@johnoro johnoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job!

where PostalCode = 1010;

select * from customers
where PostalCode = '1010';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a duplicate here.

where SupplierID = 11;

select * from Suppliers
where SupplierID = 11;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here as well

select orders.CustomerID, customers.CustomerName, count(customers.customerID)
from Orders
inner join Customers
on Orders.CustomerID=Customers.CustomerID;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using aliases here would make this a good bit easier/shorter. This also looks a little off, but close!

@johnoro johnoro merged commit fa44d4f into master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants