Skip to content

Commit

Permalink
Building firectl requires at least Go 1.14 (firecracker-microvm#61)
Browse files Browse the repository at this point in the history
Signed-off-by: Volker Simonis <[email protected]>
  • Loading branch information
simonis authored Jul 12, 2022
1 parent ee76e3c commit 94ac8f8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ else
endif

build-in-docker:
docker run --rm -v $(CURDIR):/firectl --workdir /firectl golang:1.12 make
docker run --rm -v $(CURDIR):/firectl --workdir /firectl golang:1.14 make

test:
go test -v ./...
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ Building

The default Makefile rule executes `go build` and relies on the Go toolchain
installed on your computer.
_We use [go modules](https://github.com/golang/go/wiki/Modules), so you need to
build with Go 1.11 or newer._
_We use [go modules](https://github.com/golang/go/wiki/Modules), and building
requires Go 1.14 or newer._

If you do not have a new-enough Go toolchain installed, you can use `make
build-in-docker`. This rule creates a temporary Docker container which builds
Expand Down

0 comments on commit 94ac8f8

Please sign in to comment.