Skip to content

Commit

Permalink
Minor makefile fixes
Browse files Browse the repository at this point in the history
Set several targets as .PHONY

Use CURDIR instead of PWD when referncing the current working directory. The
former is managed by make itself, while the latter comes from the shell and
does not reflect the current directory in "make -C some/other/directory"
scenarios.

Signed-off-by: Noah Meyerhans <[email protected]>
  • Loading branch information
Noah Meyerhans committed Jul 1, 2019
1 parent 9dc0220 commit fc57478
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ else
endif

build-in-docker:
docker run --rm -v ${PWD}:/firectl --workdir /firectl golang:1.12 make
docker run --rm -v $(CURDIR):/firectl --workdir /firectl golang:1.12 make

test:
go test -v ./...
Expand All @@ -45,4 +45,4 @@ clean:
install:
install -o root -g root -m755 firectl $(BINDIR)/

.PHONY: all clean install
.PHONY: all clean install build-in-docker test lint release

0 comments on commit fc57478

Please sign in to comment.