fix(third_party): use submodule for Eigen

MegviiRobot · Dec 13, 2023 · bd86dc0 · bd86dc0
1 parent 4aaaad2
commit bd86dc0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/.gitmodules b/.gitmodules
@@ -0,0 +1,3 @@
+[submodule "third_party/eigen"]
+	path = third_party/eigen
+	url = https://gitlab.com/libeigen/eigen.git
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -41,7 +41,8 @@ option(MEGBA_ENABLE_EXAMPLE "BUILD EXAMPLES" TRUE)
 # CUDA
 find_package(CUDAToolkit REQUIRED)
 find_package(OpenMP REQUIRED)
-find_package(Eigen3 3.4.0 CONFIG REQUIRED)
+set(EIGEN_BUILD_TESTING OFF)
+add_subdirectory(third_party/eigen)
 find_package(Threads REQUIRED)
 if (${CMAKE_CUDA_COMPILER_VERSION} GREATER_EQUAL 11.5)
     set(Thrust_DIR /usr/local/cuda/targets/x86_64-linux/lib/cmake/thrust/)

diff --git a/README.md b/README.md
@@ -29,7 +29,6 @@ Dependencies:
 - C++14
 - CMake (>= 3.15)
 - [CUDA](https://developer.nvidia.com/cuda-downloads) (>= 11.2)
-- [Eigen](https://eigen.tuxfamily.org/) (>= 3.4.0)
 - [gflags](https://github.com/gflags/gflags)
 - NCCL2 (if you need Distributed features) https://developer.nvidia.com/nccl/nccl-download
 
@@ -45,6 +44,7 @@ Demo with BAL dataset:
   If you want to use the distributed feature, use `cmake -DMEGBA_ENABLE_NCCL ..` instead of `cmake ..`.
 
   ```bash
+  git submodule update --init
   mkdir build
   cd build
   cmake ..  # enable nccl by using cmake -DMEGBA_ENABLE_NCCL ..

diff --git a/third_party/eigen b/third_party/eigen