Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(game): legacy commands #239

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat(game): legacy commands #239

wants to merge 14 commits into from

Conversation

MeikelLP
Copy link
Owner

@MeikelLP MeikelLP commented Nov 27, 2024 •
edited
Loading

see #100

Implemented the following commands:

  • /dc
  • /reset
  • /r
  • /ipurge
  • /weak
  • /weaken
  • /makeguild
  • /deleteguild
  • /pull <-- Math should be improved but I'm too stupid
  • /forgetme
  • /aggregate
  • /who
  • /mob_ld
  • /goto

Fixed

  • disconnected state when logging out
  • Wrong expiry calculation in InMemoryRedis causing inability to login after disconnect

@MeikelLP MeikelLP added type/feature New content area/game The game app is affected labels Nov 27, 2024
@MeikelLP MeikelLP added this to the 0.1 The Baseline milestone Nov 27, 2024
@MeikelLP MeikelLP mentioned this pull request Nov 27, 2024
Open
42 tasks
@MeikelLP MeikelLP changed the title feat(game): legacy commands 2 feat(game): legacy commands Nov 29, 2024
@MeikelLP MeikelLP mentioned this pull request Dec 1, 2024
Merged
@Arichikurumo
Copy link

The following commands failed during testing:
/state -> unknown command
/mm -> unknown command
/group -> unknown command
/grrandom -> unknown command
gstate -> unknown command
/purge -> unknown command

@MeikelLP
Copy link
Owner Author

MeikelLP commented Dec 6, 2024

The following commands failed during testing: /state -> unknown command /mm -> unknown command /group -> unknown command /grrandom -> unknown command gstate -> unknown command /purge -> unknown command

Those were implemented in #236 sorry

@MeikelLP MeikelLP added the help wanted Extra attention is needed label Dec 17, 2024
@MeikelLP
Merge branch 'refs/heads/master' into feature/legacy-commands-2
6486377 
# Conflicts:
#	src/Libraries/Game.Server/World/Entities/MonsterEntity.cs
@MeikelLP MeikelLP removed the request for review from uutkukorkmaz December 18, 2024 21:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MeikelLP MeikelLP mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Arichikurumo Arichikurumo

Labels
area/game The game app is affected help wanted Extra attention is needed type/feature New content
Projects
None yet
Milestone
0.1 The Baseline
Development

Successfully merging this pull request may close these issues.
2 participants
@MeikelLP @Arichikurumo