Skip to content

Commit

Permalink
devtools: fix symbols check
Browse files Browse the repository at this point in the history
In some environments, the check of local symbols catch-all
was failing. Note: this script is called during the build.

The reason is that grep returns an error if nothing is found.
The option -e of the shell script makes this error fatal.
It is not always fatal because the grep is in a command substitution.

Fixes: b403498 ("build: hide local symbols in shared libraries")

Reported-by: Usama Arif <[email protected]>
Signed-off-by: Thomas Monjalon <[email protected]>
  • Loading branch information
tmonjalo committed Mar 8, 2022
1 parent 3b358e3 commit 272f94e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion devtools/check-symbol-maps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then
ret=1
fi

local_miss_maps=$(grep -L 'local: \*;' $@)
local_miss_maps=$(grep -L 'local: \*;' $@ || true)
if [ -n "$local_miss_maps" ] ; then
echo "Found maps without local catch-all:"
echo "$local_miss_maps"
Expand Down

0 comments on commit 272f94e

Please sign in to comment.