Fix encoding and hash function versions used in unit tests #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various unit tests for `signTypedData_v3` functions included uses of encoding and hash functions for `signTypedData_v4`. This was likely accidental, as these functions default to "v4" mode. All such uses now use the "v3" encoding. Luckily the "v3" and "v4" encoding was exactly the same for all such examples.
rekmarks
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various unit tests for
signTypedData_v3functions included uses of encoding and hash functions forsignTypedData_v4. This was likely accidental, as these functions default to "v4" mode.All such uses now use the "v3" encoding. Luckily the "v3" and "v4" encoding was exactly the same for all such examples.