-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain E2E Test: Multi dapp #29751
base: jl/caip-multichain-migrate-core
Are you sure you want to change the base?
Multichain E2E Test: Multi dapp #29751
Conversation
if (!multipleDapps) { | ||
await unlockWallet(driver); | ||
} | ||
await openDapp(driver, undefined, url); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of this extra 4th (optional) param, but I needed this util function to only unlock the wallet once for a multi dapp setup. So in the actual test we call unlockWallet
once, and then loop through dapps to actually open the dapps themselves.
Should we make another util func that's used for multi dapp setup, or other suggested approaches, or ya'll fine with this ?
|
||
// Assert | ||
for (const [i, dapp] of DAPP_URLS.entries()) { | ||
const accountWebElement = await driver.findElement( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple loops because we want to make sure we queue up all the requests first, and then make assertions that the sequence of requests, the origin and account are correct for each confirmation in the queue (as per ticket description)
Builds ready [ee1029b]
Page Load Metrics (1655 ± 64 ms)
|
-- test: multi dapp e2e test setup;
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist