Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theMiracle Benefits Tracker #978

Merged
merged 11 commits into from
Jan 23, 2025
Merged

New theMiracle Benefits Tracker #978

merged 11 commits into from
Jan 23, 2025

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Dec 16, 2024

Closes: #984

@khanti42 khanti42 marked this pull request as ready for review January 6, 2025 15:13
@khanti42 khanti42 requested review from Montoya and a team as code owners January 6, 2025 15:13
@Montoya
Copy link
Contributor

Montoya commented Jan 7, 2025

Snap is logging to console; pending changes from dev

Montoya
Montoya previously approved these changes Jan 9, 2025
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Snap requests endowment:transaction-insight but does not have a transaction insight handler. Please ask that they remove unused permissions.

@khanti42
Copy link
Collaborator Author

New version has been pushed without the endowment:transaction-insight should be good now. @FrederikBolding

@FrederikBolding FrederikBolding merged commit e5ea8d0 into main Jan 23, 2025
16 checks passed
@FrederikBolding FrederikBolding deleted the newTheMiracle branch January 23, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Snap] theMiracle Benefits Tracker
3 participants