Add end-of-namespace comments.

Generated by clang-tidy llvm-namespace-comment.

.clang-tidy

@@ -0,0 +1,15 @@
+---
+# Only run one check for now.
+Checks:          '-clang-analyzer-*,llvm-namespace-comment'
+WarningsAsErrors: ''
+HeaderFilterRegex: ''
+AnalyzeTemporaryDtors: false
+FormatStyle:     none
+User:            chenshuo
+CheckOptions:
+  - key:             llvm-namespace-comment.ShortNamespaceLines
+    value:           '10'
+  - key:             llvm-namespace-comment.SpacesBeforeComments
+    value:           '2'
+...
+

.gitignore

@@ -1 +1,2 @@
 *.swp
+compile_commands.json

CMakeLists.txt

@@ -36,7 +36,7 @@ string(REPLACE ";" " " CMAKE_CXX_FLAGS "${CXX_FLAGS}")
 
 set(CMAKE_CXX_COMPILER "g++")
 set(CMAKE_CXX_FLAGS_DEBUG "-O0")
-set(CMAKE_CXX_FLAGS_RELEASE "-O2 -finline-limit=1000 -DNDEBUG")
+set(CMAKE_CXX_FLAGS_RELEASE "-O2 -DNDEBUG")
 set(EXECUTABLE_OUTPUT_PATH ${PROJECT_BINARY_DIR}/bin)
 set(LIBRARY_OUTPUT_PATH ${PROJECT_BINARY_DIR}/lib)
 
@@ -96,7 +96,7 @@ message(STATUS "CXX_FLAGS = " ${CMAKE_CXX_FLAGS} " " ${CMAKE_CXX_FLAGS_${BUILD_T
 add_subdirectory(muduo/base)
 add_subdirectory(muduo/net)
 
-if(NOT CMAKE_BUILD_NO_EXAMPLES)
+if(NOT MUDUO_BUILD_NO_EXAMPLES)
   add_subdirectory(contrib)
   add_subdirectory(examples)
 else()

build.sh

@@ -8,12 +8,15 @@ BUILD_TYPE=${BUILD_TYPE:-release}
 INSTALL_DIR=${INSTALL_DIR:-../${BUILD_TYPE}-install-cpp11}
 BUILD_NO_EXAMPLES=${BUILD_NO_EXAMPLES:-0}
 
+ln -sf $BUILD_DIR/$BUILD_TYPE-cpp11/compile_commands.json
+
 mkdir -p $BUILD_DIR/$BUILD_TYPE-cpp11 \
   && cd $BUILD_DIR/$BUILD_TYPE-cpp11 \
   && cmake \
            -DCMAKE_BUILD_TYPE=$BUILD_TYPE \
            -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR \
-           -DCMAKE_BUILD_NO_EXAMPLES=$BUILD_NO_EXAMPLES \
+           -DMUDUO_BUILD_NO_EXAMPLES=$BUILD_NO_EXAMPLES \
+           -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
            $SOURCE_DIR \
   && make $*
 

clang.diff

@@ -29,8 +29,7 @@ diff --git a/CMakeLists.txt b/CMakeLists.txt
 -set(CMAKE_CXX_COMPILER "g++")
 +set(CMAKE_CXX_COMPILER "clang++")
  set(CMAKE_CXX_FLAGS_DEBUG "-O0")
--set(CMAKE_CXX_FLAGS_RELEASE "-O2 -finline-limit=1000 -DNDEBUG")
-+set(CMAKE_CXX_FLAGS_RELEASE "-O2 -DNDEBUG")
+ set(CMAKE_CXX_FLAGS_RELEASE "-O2 -DNDEBUG")
  set(EXECUTABLE_OUTPUT_PATH ${PROJECT_BINARY_DIR}/bin)
  set(LIBRARY_OUTPUT_PATH ${PROJECT_BINARY_DIR}/lib)
 

contrib/hiredis/Hiredis.h

@@ -85,6 +85,6 @@ class Hiredis : public std::enable_shared_from_this<Hiredis>,
   DisconnectCallback disconnectCb_;
 };
 
-}
+}  // namespace hiredis
 
 #endif  // MUDUO_EXAMPLES_HIREDIS_HIREDIS_H

examples/ace/logging/client.cc

@@ -113,7 +113,7 @@ class LogClient : noncopyable
   TcpConnectionPtr connection_ GUARDED_BY(mutex_);
 };
 
-}
+}  // namespace logging
 
 int main(int argc, char* argv[])
 {

examples/ace/logging/server.cc

@@ -115,7 +115,7 @@ class LogServer : noncopyable
   TcpServer server_;
 };
 
-}
+}  // namespace logging
 
 int main(int argc, char* argv[])
 {

examples/ace/ttcp/ttcp.cc

@@ -97,7 +97,7 @@ void onMessage(const TcpConnectionPtr& conn, Buffer* buf, Timestamp time)
   }
 }
 
-}
+}  // namespace trans
 
 void transmit(const Options& opt)
 {
@@ -197,7 +197,7 @@ void onMessage(const TcpConnectionPtr& conn, Buffer* buf, Timestamp time)
   }
 }
 
-}
+}  // namespace receiving
 
 void receive(const Options& opt)
 {

examples/cdns/Resolver.cc

@@ -38,7 +38,7 @@ const char* getSocketType(int type)
 }
 
 const bool kDebug = false;
-}
+}  // namespace
 
 Resolver::Resolver(EventLoop* loop, Option opt)
   : loop_(loop),

examples/cdns/Resolver.h

@@ -71,6 +71,6 @@ class Resolver : muduo::noncopyable
   static int ares_sock_create_callback(int sockfd, int type, void* data);
   static void ares_sock_state_callback(void* data, int sockfd, int read, int write);
 };
-}
+}  // namespace cdns
 
 #endif

examples/curl/Curl.h

@@ -137,6 +137,6 @@ class Curl : muduo::noncopyable
   int prevRunningHandles_;
 };
 
-}
+}  // namespace curl
 
 #endif

examples/hub/codec.h

@@ -21,7 +21,7 @@ ParseResult parseMessage(muduo::net::Buffer* buf,
                          string* cmd,
                          string* topic,
                          string* content);
-}
+}  // namespace pubsub
 
 #endif  // MUDUO_EXAMPLES_HUB_CODEC_H
 

examples/hub/hub.cc

@@ -193,7 +193,7 @@ class PubSubServer : noncopyable
   std::map<string, Topic> topics_;
 };
 
-}
+}  // namespace pubsub
 
 int main(int argc, char* argv[])
 {

examples/hub/pubsub.h

@@ -42,6 +42,6 @@ class PubSubClient : muduo::noncopyable
   ConnectionCallback connectionCallback_;
   SubscribeCallback subscribeCallback_;
 };
-}
+}  // namespace pubsub
 
 #endif  // MUDUO_EXAMPLES_HUB_PUBSUB_H

examples/protobuf/resolver/server.cc

@@ -68,7 +68,7 @@ class ResolverServiceImpl : public ResolverService
   cdns::Resolver resolver_;
 };
 
-}
+}  // namespace resolver
 
 int main()
 {

examples/protobuf/rpc/server.cc

@@ -27,7 +27,7 @@ class SudokuServiceImpl : public SudokuService
   }
 };
 
-}
+}  // namespace sudoku
 
 int main()
 {

examples/protobuf/rpcbench/server.cc

@@ -26,7 +26,7 @@ class EchoServiceImpl : public EchoService
   }
 };
 
-}
+}  // namespace echo
 
 int main(int argc, char* argv[])
 {

muduo/base/AsyncLogging.h

@@ -67,5 +67,6 @@ class AsyncLogging : noncopyable
   BufferVector buffers_ GUARDED_BY(mutex_);
 };
 
-}
+}  // namespace muduo
+
 #endif  // MUDUO_BASE_ASYNCLOGGING_H

muduo/base/Atomic.h

@@ -87,10 +87,11 @@ class AtomicIntegerT : noncopyable
  private:
   volatile T value_;
 };
-}
+}  // namespace detail
 
 typedef detail::AtomicIntegerT<int32_t> AtomicInt32;
 typedef detail::AtomicIntegerT<int64_t> AtomicInt64;
-}
+
+}  // namespace muduo
 
 #endif  // MUDUO_BASE_ATOMIC_H

muduo/base/BlockingQueue.h

@@ -67,6 +67,6 @@ class BlockingQueue : noncopyable
   std::deque<T>     queue_ GUARDED_BY(mutex_);
 };
 
-}
+}  // namespace muduo
 
 #endif  // MUDUO_BASE_BLOCKINGQUEUE_H

muduo/base/BoundedBlockingQueue.h

@@ -84,6 +84,6 @@ class BoundedBlockingQueue : noncopyable
   boost::circular_buffer<T>  queue_ GUARDED_BY(mutex_);
 };
 
-}
+}  // namespace muduo
 
 #endif  // MUDUO_BASE_BOUNDEDBLOCKINGQUEUE_H

muduo/base/Condition.h

@@ -51,5 +51,6 @@ class Condition : noncopyable
   pthread_cond_t pcond_;
 };
 
-}
+}  // namespace muduo
+
 #endif  // MUDUO_BASE_CONDITION_H

muduo/base/CountDownLatch.h

@@ -30,5 +30,5 @@ class CountDownLatch : noncopyable
   int count_ GUARDED_BY(mutex_);
 };
 
-}
+}  // namespace muduo
 #endif  // MUDUO_BASE_COUNTDOWNLATCH_H

muduo/base/CurrentThread.h

@@ -46,7 +46,7 @@ namespace CurrentThread
   bool isMainThread();
 
   void sleepUsec(int64_t usec);
-}
-}
+}  // namespace CurrentThread
+}  // namespace muduo
 
 #endif

muduo/base/Date.cc

@@ -40,9 +40,9 @@ struct Date::YearMonthDay getYearMonthDay(int julianDayNumber)
   ymd.year = b * 100 + d - 4800 + (m / 10);
   return ymd;
 }
-}
+}  // namespace detail
 const int Date::kJulianDayOf1970_01_01 = detail::getJulianDayNumber(1970, 1, 1);
-}
+}  // namespace muduo
 
 using namespace muduo;
 using namespace muduo::detail;

muduo/base/Date.h

@@ -114,5 +114,6 @@ inline bool operator==(Date x, Date y)
   return x.julianDayNumber() == y.julianDayNumber();
 }
 
-}
+}  // namespace muduo
+
 #endif  // MUDUO_BASE_DATE_H

muduo/base/Exception.h

@@ -28,6 +28,6 @@ class Exception : public std::exception
   string stack_;
 };
 
-}
+}  // namespace muduo
 
 #endif  // MUDUO_BASE_EXCEPTION_H

muduo/base/FileUtil.h

@@ -16,7 +16,6 @@
 
 namespace muduo
 {
-
 namespace FileUtil
 {
 
@@ -84,9 +83,9 @@ class AppendFile : noncopyable
   char buffer_[64*1024];
   off_t writtenBytes_;
 };
-}
 
-}
+}  // namespace FileUtil
+}  // namespace muduo
 
 #endif  // MUDUO_BASE_FILEUTIL_H
 

muduo/base/GzipFile.h

@@ -81,4 +81,4 @@ class GzipFile : noncopyable
   gzFile file_;
 };
 
-}
+}  // namespace muduo

muduo/base/LogFile.h

@@ -49,5 +49,5 @@ class LogFile : noncopyable
   const static int kRollPerSeconds_ = 60*60*24;
 };
 
-}
+}  // namespace muduo
 #endif  // MUDUO_BASE_LOGFILE_H

muduo/base/LogStream.cc

@@ -74,8 +74,8 @@ size_t convertHex(char buf[], uintptr_t value)
 template class FixedBuffer<kSmallBuffer>;
 template class FixedBuffer<kLargeBuffer>;
 
-}
-}
+}  // namespace detail
+}  // namespace muduo
 
 template<int SIZE>
 const char* FixedBuffer<SIZE>::debugString()

muduo/base/LogStream.h

@@ -72,7 +72,7 @@ class FixedBuffer : noncopyable
   char* cur_;
 };
 
-}
+}  // namespace detail
 
 class LogStream : noncopyable
 {
@@ -193,6 +193,6 @@ inline LogStream& operator<<(LogStream& s, const Fmt& fmt)
   return s;
 }
 
-}
-#endif  // MUDUO_BASE_LOGSTREAM_H
+}  // namespace muduo
 
+#endif  // MUDUO_BASE_LOGSTREAM_H

muduo/base/Logging.cc

@@ -104,7 +104,7 @@ Logger::OutputFunc g_output = defaultOutput;
 Logger::FlushFunc g_flush = defaultFlush;
 TimeZone g_logTimeZone;
 
-}
+}  // namespace muduo
 
 using namespace muduo;
 

muduo/base/Logging.h

@@ -149,6 +149,6 @@ T* CheckNotNull(Logger::SourceFile file, int line, const char *names, T* ptr)
   return ptr;
 }
 
-}
+}  // namespace muduo
 
 #endif  // MUDUO_BASE_LOGGING_H

muduo/base/Mutex.h

@@ -223,7 +223,7 @@ class SCOPED_CAPABILITY MutexLockGuard : noncopyable
   MutexLock& mutex_;
 };
 
-}
+}  // namespace muduo
 
 // Prevent misuse like:
 // MutexLockGuard(mutex_);

muduo/base/ProcessInfo.cc

@@ -58,8 +58,8 @@ Timestamp g_startTime = Timestamp::now();
 // assume those won't change during the life time of a process.
 int g_clockTicks = static_cast<int>(::sysconf(_SC_CLK_TCK));
 int g_pageSize = static_cast<int>(::sysconf(_SC_PAGE_SIZE));
-}
-}
+}  // namespace detail
+}  // namespace muduo
 
 using namespace muduo;
 using namespace muduo::detail;

muduo/base/ProcessInfo.h

@@ -62,8 +62,8 @@ namespace ProcessInfo
 
   int numThreads();
   std::vector<pid_t> threads();
-}
+}  // namespace ProcessInfo
 
-}
+}  // namespace muduo
 
 #endif  // MUDUO_BASE_PROCESSINFO_H