qtest: Be paranoid about accept() addrlen argument

POSIX specifies that address_len shall on output specify the length of the stored address; it does not however specify whether it may get updated on failure as well to, e.g., zero. In case EINTR occurs, re-initialize the variable to the desired value. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
Mic92 · May 5, 2014 · 535b456 · 535b456
1 parent a7d915f
commit 535b456
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/tests/libqtest.c b/tests/libqtest.c
@@ -89,8 +89,8 @@ static int socket_accept(int sock)
     setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO, (void *)&timeout,
                sizeof(timeout));
 
-    addrlen = sizeof(addr);
     do {
+        addrlen = sizeof(addr);
         ret = accept(sock, (struct sockaddr *)&addr, &addrlen);
     } while (ret == -1 && errno == EINTR);
     if (ret == -1) {