Merge pull request aio-libs#286 from aio-libs/fix_position_reset_afte…

…r_assign Refactoring to allow fetcher to always reset offsets properly.
MichalMazurek · Jan 25, 2018 · 6eaf210 · 6eaf210
2 parents abc1da9 + d3b407b
commit 6eaf210
Show file tree

Hide file tree

Showing 16 changed files with 3,322 additions and 1,361 deletions.
diff --git a/README.rst b/README.rst
@@ -94,3 +94,11 @@ Running tests::
 To run tests with a specific version of Kafka (default one is 0.10.1.0) use KAFKA_VERSION variable::
 
     make cov KAFKA_VERSION=0.10.0.0
+
+Test running cheatsheat:
+
+ * ``make test FLAGS="-l -x --ff"`` - run until 1 failure, rerun failed tests fitst. Great for cleaning up a lot of errors, say after a big refactor.
+ * ``make test FLAGS="-k consumer"`` - run only the consumer tests.
+ * ``make test FLAGS="-m 'not ssl'"`` - run tests excluding ssl.
+ * ``make test FLAGS="--no-pull"`` - do not try to pull new docker image before test run.
+
diff --git a/aiokafka/client.py b/aiokafka/client.py
@@ -421,7 +421,7 @@ def check_version(self, node_id=None):
         """Attempt to guess the broker version"""
         if node_id is None:
             default_group_conns = [
-                node_id for (node_id, group) in self._conns.keys()
+                n_id for (n_id, group) in self._conns.keys()
                 if group == ConnectionGroup.DEFAULT
             ]
             if default_group_conns:

diff --git a/aiokafka/consumer/consumer.py b/aiokafka/consumer/consumer.py