Add spec for CoreWebView2ControllerOptions.DefaultBackgroundColor.md for review #4981
+133
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to address feedback from review comments
…rOptions.DefaultBackgroundColor-draft Add spec for CoreWebView2ControllerOptions.DefaultBackgroundColor.md
FrankC-msft
reviewed
Dec 12, 2024
| /// By default, this color is set to white. | ||
| /// | ||
| /// Currently this API only supports opaque colors and transparency. It will | ||
| /// fail for colors with alpha values that don't equal 0 or 255 ie. translucent |
There was a problem hiding this comment.
"Fail" means throws e_invalidarg from the setter, correct?
| /// the `DefaultBackgroundColor` property to render the background. | ||
| /// By default, this color is set to white. | ||
| /// | ||
| /// Currently this API only supports opaque colors and transparency. It will |
There was a problem hiding this comment.
"Currently" suggests this is a temporary limitation. If we don't have concrete plans to support semi-transparent colors, consider simplifying this by removing the adverb.
(I presume future support for semi-transparent would mean a new interface with a readonly property indicating support.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.