Skip to content

Commit

Permalink
Bug 17332: Remove memcached config from apache files
Browse files Browse the repository at this point in the history
This patch removes Memcached configurations from the shipped apache files.

Note: testing is not actually needed for this patch, as it is really trivial. But I
include testing steps, just in case QA members require it.

To test:
- Apply the patch
- Do a (standard/dev/single) Koah install
=> SUCCESS: Verify the resulting koha-httpd.conf file doens't include memcached data
- Have a packages install
- Replace
  * /etc/koha/apache-site-https.conf.in
  * /etc/koha/apache-site.conf.in
  with the ones from this patch
- Create an instance
=> SUCCESS: The apache configuration doesn't include memcached configurations
- Sign off :-D

Signed-off-by: Chris Cormack <[email protected]>

Signed-off-by: Kyle M Hall <[email protected]>

Signed-off-by: Kyle M Hall <[email protected]>
  • Loading branch information
tomascohen authored and kylemhall committed Sep 25, 2016
1 parent 1c957af commit ea5ec8c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
4 changes: 0 additions & 4 deletions debian/templates/apache-site-https.conf.in
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@

ServerName __OPACSERVER__
SetEnv KOHA_CONF "/etc/koha/sites/__KOHASITE__/koha-conf.xml"
SetEnv MEMCACHED_SERVERS "__MEMCACHED_SERVERS__"
SetEnv MEMCACHED_NAMESPACE "__MEMCACHED_NAMESPACE__"
AssignUserID __UNIXUSER__ __UNIXGROUP__

ErrorLog /var/log/koha/__KOHASITE__/opac-error.log
Expand Down Expand Up @@ -60,8 +58,6 @@

ServerName __INTRASERVER__
SetEnv KOHA_CONF "/etc/koha/sites/__KOHASITE__/koha-conf.xml"
SetEnv MEMCACHED_SERVERS "__MEMCACHED_SERVERS__"
SetEnv MEMCACHED_NAMESPACE "__MEMCACHED_NAMESPACE__"
AssignUserID __UNIXUSER__ __UNIXGROUP__

ErrorLog /var/log/koha/__KOHASITE__/intranet-error.log
Expand Down
6 changes: 1 addition & 5 deletions debian/templates/apache-site.conf.in
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@

ServerName __OPACSERVER__
SetEnv KOHA_CONF "/etc/koha/sites/__KOHASITE__/koha-conf.xml"
SetEnv MEMCACHED_SERVERS "__MEMCACHED_SERVERS__"
SetEnv MEMCACHED_NAMESPACE "__MEMCACHED_NAMESPACE__"
AssignUserID __UNIXUSER__ __UNIXGROUP__

ErrorLog /var/log/koha/__KOHASITE__/opac-error.log
Expand All @@ -30,11 +28,9 @@
# Include /etc/koha/apache-shared-disable.conf
# Include /etc/koha/apache-shared-intranet-plack.conf
Include /etc/koha/apache-shared-intranet.conf

ServerName __INTRASERVER__
SetEnv KOHA_CONF "/etc/koha/sites/__KOHASITE__/koha-conf.xml"
SetEnv MEMCACHED_SERVERS "__MEMCACHED_SERVERS__"
SetEnv MEMCACHED_NAMESPACE "__MEMCACHED_NAMESPACE__"
AssignUserID __UNIXUSER__ __UNIXGROUP__

ErrorLog /var/log/koha/__KOHASITE__/intranet-error.log
Expand Down
4 changes: 0 additions & 4 deletions etc/koha-httpd.conf
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
# TransferLog __LOG_DIR__/koha-opac-access.log
SetEnv KOHA_CONF "__KOHA_CONF_DIR__/koha-conf.xml"
SetEnv PERL5LIB "__PERL_MODULE_DIR__"
SetEnv MEMCACHED_SERVERS "__MEMCACHED_SERVERS__"
SetEnv MEMCACHED_NAMESPACE "__MEMCACHED_NAMESPACE__"

# This syntax allows you to override a system preference
# for a given virtual host. Use with caution!
Expand Down Expand Up @@ -145,8 +143,6 @@
# TransferLog __LOG_DIR__/koha-access.log
SetEnv KOHA_CONF "__KOHA_CONF_DIR__/koha-conf.xml"
SetEnv PERL5LIB "__PERL_MODULE_DIR__"
SetEnv MEMCACHED_SERVERS "__MEMCACHED_SERVERS__"
SetEnv MEMCACHED_NAMESPACE "__MEMCACHED_NAMESPACE__"
Options +FollowSymLinks

# If you are overriding any system preferences,
Expand Down

0 comments on commit ea5ec8c

Please sign in to comment.