chore: refactor test structure (heyxyz#3147)

* feat: move web test cases to its own * feat: move prerender test cases to its own * chore: remove nightly tests * chore: temp remove global tests folder * fix: lint errors
Mint0903 · Jun 20, 2023 · b1eba13 · b1eba13
1 parent 4c64d5c
commit b1eba13
Show file tree

Hide file tree

Showing 71 changed files with 51 additions and 1,122 deletions.
diff --git a/.deepsource.toml b/.deepsource.toml
@@ -6,7 +6,6 @@ exclude_patterns = [
   ".github",
   ".husky",
   ".vscode",
-  "tests",
   "pnpm-lock.yaml",
   "packages/lens/generated.ts",
   "packages/workers/snapshot-relay/generated.ts",

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
diff --git a/apps/prerender/package.json b/apps/prerender/package.json
@@ -11,6 +11,7 @@
     "prettier": "prettier --check \"**/*.{js,ts,tsx,md}\"  --cache",
     "prettier:fix": "prettier --write \"**/*.{js,ts,tsx,md}\"  --cache",
     "start": "next start --port 4784",
+    "test:dev": "playwright test",
     "typecheck": "tsc --pretty"
   },
   "dependencies": {
@@ -28,6 +29,7 @@
   "devDependencies": {
     "@lenster/config": "workspace:*",
     "@lenster/lens": "workspace:*",
+    "@playwright/test": "^1.35.1",
     "@types/react": "^18.2.13",
     "@types/react-dom": "^18.2.6",
     "typescript": "^5.1.3"

diff --git a/tests/playwright.config.ts → apps/prerender/playwright.config.ts b/tests/playwright.config.ts → apps/prerender/playwright.config.ts
diff --git a/apps/prerender/tests/constants.ts b/apps/prerender/tests/constants.ts
@@ -0,0 +1 @@
+export const PRERENDER_BASE_URL = 'http://localhost:4784';
diff --git a/tests/apps/prerender/profile.spec.ts → apps/prerender/tests/profile.spec.ts b/tests/apps/prerender/profile.spec.ts → apps/prerender/tests/profile.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { PRERENDER_BASE_URL } from 'test/constants';
+import { PRERENDER_BASE_URL } from 'tests/constants';
 
 test.beforeEach(async ({ page }) => {
   await page.goto(`${PRERENDER_BASE_URL}/u/yoginth`);

diff --git a/tests/apps/prerender/publication.spec.ts → apps/prerender/tests/publication.spec.ts b/tests/apps/prerender/publication.spec.ts → apps/prerender/tests/publication.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { PRERENDER_BASE_URL } from 'test/constants';
+import { PRERENDER_BASE_URL } from 'tests/constants';
 
 test.beforeEach(async ({ page }) => {
   await page.goto(`${PRERENDER_BASE_URL}/posts/0x0d-0x01`);

diff --git a/apps/web/package.json b/apps/web/package.json
@@ -12,6 +12,7 @@
     "prettier": "prettier --check \"**/*.{js,ts,tsx,md}\"  --cache",
     "prettier:fix": "prettier --write \"**/*.{js,ts,tsx,md}\"  --cache",
     "start": "next start --port 4783",
+    "test:dev": "playwright test",
     "typecheck": "tsc --pretty"
   },
   "dependencies": {
@@ -90,6 +91,7 @@
     "@giphy/js-types": "^4.4.0",
     "@lenster/config": "workspace:*",
     "@lingui/cli": "^4.2.1",
+    "@playwright/test": "^1.35.1",
     "@tailwindcss/aspect-ratio": "^0.4.2",
     "@tailwindcss/forms": "^0.5.3",
     "@types/node": "^20.3.1",

diff --git a/apps/web/playwright.config.ts b/apps/web/playwright.config.ts
@@ -0,0 +1,19 @@
+import type { PlaywrightTestConfig } from '@playwright/test';
+import { devices } from '@playwright/test';
+import * as os from 'os';
+
+const config: PlaywrightTestConfig = {
+  testDir: './',
+  timeout: 50 * 1000,
+  expect: { timeout: 50000 },
+  fullyParallel: true,
+  maxFailures: 3,
+  forbidOnly: Boolean(process.env.CI),
+  retries: 3,
+  workers: os.cpus().length === 1 ? 1 : os.cpus().length - 1,
+  reporter: 'list',
+  use: { actionTimeout: 0, trace: 'on-first-retry' },
+  projects: [{ name: 'chromium', use: { ...devices['Desktop Chrome'] } }]
+};
+
+export default config;
diff --git a/apps/web/src/components/Comment/Feed.tsx b/apps/web/src/components/Comment/Feed.tsx
@@ -64,7 +64,6 @@ const Feed: FC<FeedProps> = ({ publication }) => {
   ).length;
   const hiddenRemovedComments = comments?.length - hiddenCount;
   const totalComments = hiddenRemovedComments + queuedCount;
-  const canComment = publication?.canComment?.result;
 
   const { observe } = useInView({
     onChange: async ({ inView }) => {

diff --git a/apps/web/src/components/Messages/Composer.tsx b/apps/web/src/components/Messages/Composer.tsx
@@ -209,6 +209,7 @@ const Composer: FC<ComposerProps> = ({
   useEffect(() => {
     setMessage(unsentMessage ?? '');
     // only run this effect when the conversation changes
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [conversationKey]);
 
   const onChangeCallback = (value: string) => {

diff --git a/apps/web/src/components/Messages/Message.tsx b/apps/web/src/components/Messages/Message.tsx
@@ -116,6 +116,7 @@ const Message: FC<MessageProps> = ({ conversationKey }) => {
       }
     }
     // only run this effect when messages changes
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [messages]);
 
   const fetchNextMessages = useCallback(() => {

diff --git a/apps/web/tests/constants.ts b/apps/web/tests/constants.ts
@@ -0,0 +1 @@
+export const WEB_BASE_URL = 'http://localhost:4783';
diff --git a/tests/apps/web/contact.spec.ts → apps/web/tests/contact.spec.ts b/tests/apps/web/contact.spec.ts → apps/web/tests/contact.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.beforeEach(async ({ page }) => {
   await page.goto(`${WEB_BASE_URL}/contact`);

diff --git a/tests/apps/web/explore.spec.ts → apps/web/tests/explore.spec.ts b/tests/apps/web/explore.spec.ts → apps/web/tests/explore.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.beforeEach(async ({ page }) => {
   await page.goto(`${WEB_BASE_URL}/explore`);

diff --git a/tests/apps/web/home.spec.ts → apps/web/tests/home.spec.ts b/tests/apps/web/home.spec.ts → apps/web/tests/home.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.beforeEach(async ({ page }) => {
   await page.goto(WEB_BASE_URL);

diff --git a/tests/apps/web/layout.spec.ts → apps/web/tests/layout.spec.ts b/tests/apps/web/layout.spec.ts → apps/web/tests/layout.spec.ts
@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.beforeEach(async ({ page }) => {
   await page.goto(WEB_BASE_URL);

diff --git a/tests/apps/web/privacy.spec.ts → apps/web/tests/privacy.spec.ts b/tests/apps/web/privacy.spec.ts → apps/web/tests/privacy.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.beforeEach(async ({ page }) => {
   await page.goto(`${WEB_BASE_URL}/privacy`);

diff --git a/tests/apps/web/profile/feeds.spec.ts → apps/web/tests/profile/feeds.spec.ts b/tests/apps/web/profile/feeds.spec.ts → apps/web/tests/profile/feeds.spec.ts
@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.describe('Profile feeds', () => {
   test.beforeEach(async ({ page }) => {

diff --git a/tests/apps/web/profile/profile.spec.ts → apps/web/tests/profile/profile.spec.ts b/tests/apps/web/profile/profile.spec.ts → apps/web/tests/profile/profile.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.describe('Profile', () => {
   test.beforeEach(async ({ page }) => {

diff --git a/tests/apps/web/profile/sidebar.spec.ts → apps/web/tests/profile/sidebar.spec.ts b/tests/apps/web/profile/sidebar.spec.ts → apps/web/tests/profile/sidebar.spec.ts
@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.describe('Profile sidebar', () => {
   test.describe('Profile details', () => {

diff --git a/...s/apps/web/publication/attachment.spec.ts → .../web/tests/publication/attachment.spec.ts b/...s/apps/web/publication/attachment.spec.ts → .../web/tests/publication/attachment.spec.ts
@@ -1,6 +1,6 @@
 import { IPFS_GATEWAY } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.describe('Publication attachments', () => {
   test('should have publication image', async ({ page }) => {
@@ -53,7 +53,7 @@ test.describe('Publication attachments', () => {
   });
 
   test.describe('Publication oembed', () => {
-    test('should have normal oembed', async ({ page }) => {
+    test.skip('should have normal oembed', async ({ page }) => {
       const publicationId = '0x0d-0x0375';
       await page.goto(`${WEB_BASE_URL}/posts/${publicationId}`);
 

diff --git a/.../apps/web/publication/publication.spec.ts → ...web/tests/publication/publication.spec.ts b/.../apps/web/publication/publication.spec.ts → ...web/tests/publication/publication.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.describe('Publication', () => {
   test.beforeEach(async ({ page }) => {
@@ -62,7 +62,7 @@ test.describe('Publication', () => {
       const publicationMirrorStats = page
         .getByTestId('publication-0x0d-0x01')
         .getByTestId('mirror-stats');
-      await expect(publicationMirrorStats).toContainText('Mirror');
+      await expect(publicationMirrorStats).toContainText('Mirrors');
 
       // click mirror stats and check if it opens mirror modal
       await publicationMirrorStats.click();

diff --git a/tests/apps/web/publication/sidebar.spec.ts → apps/web/tests/publication/sidebar.spec.ts b/tests/apps/web/publication/sidebar.spec.ts → apps/web/tests/publication/sidebar.spec.ts
@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.describe('Publication sidebar', () => {
   test.beforeEach(async ({ page }) => {

diff --git a/tests/apps/web/terms.spec.ts → apps/web/tests/terms.spec.ts b/tests/apps/web/terms.spec.ts → apps/web/tests/terms.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 test.beforeEach(async ({ page }) => {
   await page.goto(`${WEB_BASE_URL}/terms`);

diff --git a/tests/apps/web/utils.spec.ts → apps/web/tests/utils.spec.ts b/tests/apps/web/utils.spec.ts → apps/web/tests/utils.spec.ts
@@ -1,6 +1,6 @@
 import { APP_NAME } from '@lenster/data/constants';
 import { expect, test } from '@playwright/test';
-import { WEB_BASE_URL } from 'test/constants';
+import { WEB_BASE_URL } from 'tests/constants';
 
 // Check footer is present
 test('should have footer', async ({ page }) => {

diff --git a/package.json b/package.json
@@ -19,7 +19,6 @@
     "start": "turbo run start --parallel",
     "test:dev": "turbo run test:dev",
     "test:e2e": "start-server-and-test start '4783|4784|8083|8085|8087' test:dev",
-    "test:nightly": "turbo run test:nightly",
     "typecheck": "turbo run typecheck --parallel",
     "typecheck:affected": "turbo run typecheck --parallel --filter=[origin/main]",
     "workers:deploy": "turbo run worker:deploy --parallel",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -2,4 +2,3 @@ packages:
   - 'apps/*'
   - 'packages/*'
   - 'packages/workers/*'
-  - 'tests'
diff --git a/tests/.eslintrc.js b/tests/.eslintrc.js
diff --git a/tests/README.md b/tests/README.md
diff --git a/tests/constants.ts b/tests/constants.ts
diff --git a/tests/package.json b/tests/package.json
diff --git a/tests/packages/lib/formatAddress.spec.ts b/tests/packages/lib/formatAddress.spec.ts
diff --git a/tests/packages/lib/formatHandle.spec.ts b/tests/packages/lib/formatHandle.spec.ts
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export const PRERENDER_BASE_URL = 'http://localhost:4784';
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export const WEB_BASE_URL = 'http://localhost:4783';