Don't retry when reset to a middle of a batch to save perf (cadence-w…

…orkflow#3721)
MirrorFork · Nov 2, 2020 · 0727b17 · 0727b17
1 parent 6e5f9ec
commit 0727b17
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/service/history/execution/state_rebuilder.go b/service/history/execution/state_rebuilder.go
@@ -162,10 +162,14 @@ func (r *stateRebuilderImpl) Rebuild(
 		baseLastEventID,
 		baseLastEventVersion,
 	)) {
-		return nil, 0, &shared.InternalServiceError{Message: fmt.Sprintf(
-			"nDCStateRebuilder unable to rebuild mutable state to event ID: %v, version: %v",
+		return nil, 0, &shared.BadRequestError{Message: fmt.Sprintf(
+			"nDCStateRebuilder unable to rebuild mutable state to event ID: %v, version: %v, "+
+				"baseLastEventID + baseLastEventVersion is not the same as the last event of the last "+
+				"batch, event ID: %v, version :%v ,typicaly because of attemptting to rebuild to a middle of a batch",
 			baseLastEventID,
 			baseLastEventVersion,
+			lastItem.EventID,
+			lastItem.Version,
 		)}
 	}