Skip to content

Commit

Permalink
Build Linux wheels in custom images. (pantsbuild#17967)
Browse files Browse the repository at this point in the history
These are the standard manylinux images, with the aws cli installed.

We need the awscli to publish the wheels to S3, and our on-the-fly
installation doesn't work for aarch64 because we don't run as
root in the image.
  • Loading branch information
benjyw authored Jan 11, 2023
1 parent 63ade26 commit 29f943d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ jobs:
timeout-minutes: 60
build_wheels_linux_arm64:
container:
image: quay.io/pypa/manylinux2014_aarch64:latest
image: registry.hub.docker.com/pantsbuild/wheel_build_aarch64:v1-568cfc69e
options: --user 1000:1000
env:
PANTS_REMOTE_CACHE_READ: 'false'
Expand Down Expand Up @@ -401,7 +401,7 @@ jobs:
timeout-minutes: 90
build_wheels_linux_x86_64:
container:
image: quay.io/pypa/manylinux2014_x86_64:latest
image: registry.hub.docker.com/pantsbuild/wheel_build_x86_64:v1-568cfc69e
env:
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
Expand Down
4 changes: 2 additions & 2 deletions build-support/bin/generate_github_workflows.py
Original file line number Diff line number Diff line change
Expand Up @@ -701,12 +701,12 @@ def build_wheels_job(platform: Platform, python_versions: list[str]) -> Jobs:
# the code, install rustup and expose Pythons.
# TODO: Apply rust caching here.
if platform == Platform.LINUX_X86_64:
container = {"image": "quay.io/pypa/manylinux2014_x86_64:latest"}
container = {"image": "registry.hub.docker.com/pantsbuild/wheel_build_x86_64:v1-568cfc69e"}
elif platform == Platform.LINUX_ARM64:
# Unfortunately Equinix do not support the CentOS 7 image on the hardware we've been
# generously given by the Runs on ARM program. Se we have to build in this image.
container = {
"image": "quay.io/pypa/manylinux2014_aarch64:latest",
"image": "registry.hub.docker.com/pantsbuild/wheel_build_aarch64:v1-568cfc69e",
# The uid/gid for the gha user and group we set up on the self-hosted runner.
# Necessary to avoid https://github.com/actions/runner/issues/434.
# Alternatively we could run absolutely everything in a container,
Expand Down

0 comments on commit 29f943d

Please sign in to comment.