Refactor ObjectCache::DeleteUnusedObjects with reverse iterator

MonkeybreadSoftware · May 17, 2021 · 42e4b91 · 42e4b91
1 parent d4bcbbd
commit 42e4b91
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/ccutil/object_cache.h b/src/ccutil/object_cache.h
@@ -95,10 +95,10 @@ class ObjectCache {
 
   void DeleteUnusedObjects() {
     std::lock_guard<std::mutex> guard(mu_);
-    for (int i = (int)cache_.size() - 1; i >= 0; i--) {
-      if (cache_[i].count <= 0) {
-        delete cache_[i].object;
-        cache_.erase(cache_.begin() + i);
+    for (auto it = cache_.rbegin(); it != cache_.rend(); ++it) {
+      if (it->count <= 0) {
+        delete it->object;
+        cache_.erase(std::next(it).base());
       }
     }
   }