Skip to content

Commit

Permalink
Explicitly package vm and isolate snapshots on desktop and embedder t…
Browse files Browse the repository at this point in the history
…argets. (flutter#5368)

These snapshots used to be included (from the runtime target) in the executable if AOT mode was disabled. The mobile shells now include this snapshot in the kernel snapshot generated on the host. However the target that run on the host still need this. The tester target was already patched but the desktop embedder targets were overlooked. The unit tests passed on the embedder target because the unit tester exectuable was including the snapshot in addition to the dylib. Now the dylib itself depends on the snapshot directly.
  • Loading branch information
chinmaygarde authored May 24, 2018
1 parent abd74ed commit e25c70c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions shell/platform/darwin/desktop/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ source_set("mac_desktop_platform") {
deps = [
"$flutter_root/common",
"$flutter_root/fml",
"$flutter_root/lib/snapshot",
"$flutter_root/shell/common",
"$flutter_root/shell/gpu",
"$flutter_root/shell/platform/darwin/common",
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/embedder/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ source_set("embedder") {
"$flutter_root/assets",
"$flutter_root/common",
"$flutter_root/fml",
"$flutter_root/lib/snapshot",
"$flutter_root/shell/common",
"$flutter_root/shell/gpu",
"//garnet/public/lib/fxl",
Expand Down Expand Up @@ -48,7 +49,6 @@ executable("embedder_unittests") {
deps = [
":embedder",
":fixtures",
"$flutter_root/lib/snapshot",
"$flutter_root/testing",
]

Expand Down

0 comments on commit e25c70c

Please sign in to comment.