Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add static typing with mypy #130

Merged
merged 4 commits into from
Sep 9, 2024
Merged

chore: add static typing with mypy #130

merged 4 commits into from
Sep 9, 2024

Conversation

fpgmaas
Copy link
Collaborator

@fpgmaas fpgmaas commented Jul 20, 2024 •
edited
Loading

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

This adds static typing with mypy. This makes it more clear to end users what expected arguments are, and helps us catch bugs earlier.

Based on top of #129, so this needs to be rebased and reviewd after that one is merged.

@fpgmaas fpgmaas changed the title chore: mypy chore: add static typing with mypy Jul 20, 2024
@fpgmaas fpgmaas requested a review from SemyonSinchenko July 20, 2024 17:57
@fpgmaas fpgmaas added this to the v0.11.0 milestone Jul 20, 2024
@fpgmaas fpgmaas marked this pull request as ready for review July 20, 2024 18:59
SemyonSinchenko
SemyonSinchenko reviewed Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments.

chispa/__init__.py Show resolved Hide resolved
chispa/bcolors.py Outdated Show resolved Hide resolved
chispa/column_comparer.py Outdated Show resolved Hide resolved
chispa/column_comparer.py Outdated Show resolved Hide resolved
chispa/number_helpers.py Outdated Show resolved Hide resolved
chispa/number_helpers.py Outdated Show resolved Hide resolved
chispa/schema_comparer.py Show resolved Hide resolved
chispa/schema_comparer.py Show resolved Hide resolved
chispa/schema_comparer.py Show resolved Hide resolved
chispa/schema_comparer.py Show resolved Hide resolved
@SemyonSinchenko
Copy link
Collaborator

@fpgmaas Hi! Is there any chance you can update the PR?

@fpgmaas
remove bcolors
c9ff3c8 
remove bcolors

fix

add mypy

add typing

fix mypy

fix mypy
@fpgmaas
update with master
0cc2798
@SemyonSinchenko
Copy link
Collaborator

Thank you!

@SemyonSinchenko SemyonSinchenko merged commit cccff07 into MrPowers:main Sep 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fpgmaas @SemyonSinchenko