Skip to content

Commit

Permalink
test/py: use default load address for tftp
Browse files Browse the repository at this point in the history
On x86_64 the size of the file u-boot loaded by the tftp test has grown in
size such that when loading the file to 0x200000 it overwrites a memory
area reserved for PCI.

If no load address is specified for tftp do not use the ram base address
(or if zero 0x200000) but the default address.

Signed-off-by: Heinrich Schuchardt <[email protected]>
  • Loading branch information
xypron authored and trini committed Feb 12, 2019
1 parent 49a9716 commit b1b1bab
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/py/tests/test_net.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,12 @@ def test_net_tftpboot(u_boot_console):
pytest.skip('No TFTP readable file to read')

addr = f.get('addr', None)
if not addr:
addr = u_boot_utils.find_ram_base(u_boot_console)

fn = f['fn']
output = u_boot_console.run_command('tftpboot %x %s' % (addr, fn))
if not addr:
output = u_boot_console.run_command('tftpboot %s' % (fn))
else:
output = u_boot_console.run_command('tftpboot %x %s' % (addr, fn))
expected_text = 'Bytes transferred = '
sz = f.get('size', None)
if sz:
Expand All @@ -163,7 +164,7 @@ def test_net_tftpboot(u_boot_console):
if u_boot_console.config.buildconfig.get('config_cmd_crc32', 'n') != 'y':
return

output = u_boot_console.run_command('crc32 %x $filesize' % addr)
output = u_boot_console.run_command('crc32 $fileaddr $filesize')
assert expected_crc in output

@pytest.mark.buildconfigspec('cmd_nfs')
Expand Down

0 comments on commit b1b1bab

Please sign in to comment.