Skip to content

Commit

Permalink
ARM: socfpga: Moving the watchdog reset to the for-loop status polling
Browse files Browse the repository at this point in the history
Current watchdog reset is misplaced after for-loop status polling, so
this poses a risk that watchdog can't be reset timely if polling taking
longer than watchdog timeout. This patch moving the watchdog reset
into polling to ensure the watchdog can be reset timely.

Signed-off-by: Tien Fong Chee <[email protected]>
  • Loading branch information
tienfong authored and Marek Vasut committed May 10, 2019
1 parent f4b53b2 commit c1cf539
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/fpga/socfpga_arria10.c
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ static int fpgamgr_program_poll_cd(void)
printf("nstatus == 0 while waiting for condone\n");
return -EPERM;
}
WATCHDOG_RESET();
}

if (i == FPGA_TIMEOUT_CNT)
Expand Down Expand Up @@ -433,7 +434,6 @@ int fpgamgr_program_finish(void)
printf("FPGA: Poll CD failed with error code %d\n", status);
return -EPERM;
}
WATCHDOG_RESET();

/* Ensure the FPGA entering user mode */
status = fpgamgr_program_poll_usermode();
Expand Down

0 comments on commit c1cf539

Please sign in to comment.