Skip to content

Commit

Permalink
MDL-32901: Default feedback plugin for gradebook was using incorrect …
Browse files Browse the repository at this point in the history
…component name

This fix allows this setting to be set to the default correctly and prevents it showing on the
front page settings screen for a new install.
  • Loading branch information
Damyon Wiese committed May 10, 2012
1 parent 3388649 commit 755bfec
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion mod/assign/settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
assign_plugin_manager::add_admin_assign_plugin_settings('assignfeedback', $ADMIN, $settings, $module);

if ($ADMIN->fulltree) {
$menu = array();
foreach (get_plugin_list('assignfeedback') as $type => $notused) {
$visible = !get_config('assignfeedback_' . $type, 'disabled');
if ($visible) {
Expand All @@ -50,7 +51,7 @@
// The default here is feedback_comments (if it exists)
$settings->add(new admin_setting_configselect('assign/feedback_plugin_for_gradebook',
new lang_string('feedbackpluginforgradebook', 'mod_assign'),
new lang_string('feedbackplugin', 'mod_assign'), 'feedback_comments', $menu));
new lang_string('feedbackplugin', 'mod_assign'), 'assignfeedback_comments', $menu));
$settings->add(new admin_setting_configcheckbox('assign/showrecentsubmissions',
new lang_string('showrecentsubmissions', 'assign'),
new lang_string('configshowrecentsubmissions', 'assign'), 0));
Expand Down

0 comments on commit 755bfec

Please sign in to comment.