MDL-23984 using standard check_dir_exists() in extlib

Mrmoodle · Aug 29, 2010 · 882efc3 · 882efc3
1 parent ab4aa56
commit 882efc3
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/files/externallib.php b/files/externallib.php
@@ -207,15 +207,10 @@ public static function upload($contextid, $component, $filearea, $itemid, $filep
             throw new moodle_exception('nofile');
         }
         // saving file
-        if (!file_exists($CFG->dataroot.'/temp/wsupload')) {
-            mkdir($CFG->dataroot.'/temp/wsupload/', 0777, true);
-        }
-
-        if (is_dir($CFG->dataroot.'/temp/wsupload')) {
-            $dir = $CFG->dataroot.'/temp/wsupload/';
-        } else {
+        if (!check_dir_exists($CFG->dataroot.'/temp/wsupload')) {
             throw new moodle_exception('cannotcreatetempdir');
         }
+
         if (empty($fileinfo['filename'])) {
             $filename = uniqid('wsupload').'_'.time().'.tmp';
         } else {