MDL-29030 migration and cleanup of stats report

AMOS BEGIN
 MOV [pluginpagetype,coursereport_stats],[pluginpagetype,report_stats]
 MOV [stats:view,coursereport_stats],[stats:view,report_stats]
AMOS END

lib/pluginlib.php

@@ -304,7 +304,7 @@ public static function standard_plugins_list($type) {
             ),
 
             'coursereport' => array(
-                'stats'
+                //deprecated!
             ),
 
             'datafield' => array(

course/report/stats/db/access.php → report/stats/db/access.php

@@ -25,7 +25,7 @@
 
 $capabilities = array(
 
-    'coursereport/stats:view' => array(
+    'report/stats:view' => array(
         'riskbitmask' => RISK_PERSONAL,
         'captype' => 'read',
         'contextlevel' => CONTEXT_COURSE,
@@ -35,7 +35,7 @@
             'manager' => CAP_ALLOW
         ),
 
-        'clonepermissionsfrom' => 'moodle/site:viewreports',
+        'clonepermissionsfrom' => 'coursereport/stats:view',
     )
 );
 

report/stats/db/install.php

@@ -0,0 +1,33 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Post installation and migration code.
+ *
+ * @package    report
+ * @subpackage stats
+ * @copyright  2011 Petr Skoda {@link http://skodak.org}
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+defined('MOODLE_INTERNAL') || die;
+
+function xmldb_report_stats_install() {
+    // this is a hack which is needed for cleanup of original coursereport_stats stuff
+    unset_all_config_for_plugin('coursereport_stats');
+    capabilities_cleanup('coursereport_stats');
+}
+

course/report/stats/graph.php → report/stats/graph.php

@@ -1,5 +1,4 @@
 <?php
-
 // This file is part of Moodle - http://moodle.org/
 //
 // Moodle is free software: you can redistribute it and/or modify
@@ -18,12 +17,13 @@
 /**
  * This file is part of the User section Moodle
  *
- * @copyright 1999 Martin Dougiamas  http://dougiamas.com
- * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- * @package course
+ * @package    report
+ * @subpackage stats
+ * @copyright  1999 onwards Martin Dougiamas (http://dougiamas.com)
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once('../../../config.php');
+require('../../config.php');
 require_once($CFG->dirroot.'/lib/statslib.php');
 require_once($CFG->dirroot.'/lib/graphlib.php');
 
@@ -34,7 +34,7 @@
 $userid   = optional_param('userid', 0, PARAM_INT);
 $roleid   = optional_param('roleid',0,PARAM_INT);
 
-$url = new moodle_url('/course/report/stats/graph.php', array('course'=>$courseid, 'report'=>$report, 'time'=>$time, 'mode'=>$mode));
+$url = new moodle_url('/report/stats/graph.php', array('course'=>$courseid, 'report'=>$report, 'time'=>$time, 'mode'=>$mode));
 if ($userid !== 0) {
     $url->param('userid', $userid);
 }
@@ -57,7 +57,7 @@
 $context = get_context_instance(CONTEXT_COURSE, $course->id);
 
 if (!$course->showreports or $USER->id != $userid) {
-    require_capability('coursereport/stats:view', $context);
+    require_capability('report/stats:view', $context);
 }
 
 stats_check_uptodate($course->id);