This is not a useful behaviour, ignore missing names in SignaturePrinter

Mu-L · Jul 13, 2021 · 581c381 · 581c381
1 parent b0cd24b
commit 581c381
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/main/java/org/spongepowered/asm/util/SignaturePrinter.java b/src/main/java/org/spongepowered/asm/util/SignaturePrinter.java
@@ -125,10 +125,6 @@ public SignaturePrinter(String name, Type returnType, Type[] argTypes, String[]
         this.returnType = returnType;
         this.argTypes = argTypes;
         this.argNames = argNames;
-        if (this.argTypes.length > this.argNames.length) {
-            throw new IllegalArgumentException(String.format("Types array length must not exceed names array length! (names=%d, types=%d)",
-                    this.argNames.length, this.argTypes.length));
-        }
     }
 
     /**
@@ -225,7 +221,8 @@ private StringBuilder appendArgs(StringBuilder sb, boolean typesOnly, boolean pr
                 }
             }
             try {
-                String name = typesOnly ? null : Strings.isNullOrEmpty(this.argNames[var]) ? "unnamed" + var : this.argNames[var];
+                String name = typesOnly ? null : var < this.argNames.length && !Strings.isNullOrEmpty(this.argNames[var])
+                        ? this.argNames[var] : "unnamed" + var;
                 this.appendType(sb, this.argTypes[var], name);
             } catch (Exception ex) {
 //                System.err.printf("\n\n>>> argTypes=%d, argNames=%d\n\n", this.argTypes.length, this.argNames.length);