[pull] master from Col-E:master #50
Open
+165,899
−58,240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
… be used as SAM/lambda interfaces
IDK the gradlew -Dwhatever just doesn't work in IntelliJ's terminal if it has dots. Weird.
…h a non-standard exit code
For now we'll just exit with a special exit code, since we crash anyways. Longer term we will want to just disable features that rely on the JDK specific code rather than exit. This includes things like: - Attaching to remote processes (jdk.attach module does not exist in JREs) - Recompiling (JavacCompiler interface has no implementations)
…UI component creation/removal Only for UI components that are navigable, which should be most of the root containers at the very least.
…ass to register loggers This will allow plugins with other package names like 'org.example' to register and have their stuff still show up in the log outputs.
…lts in many duplicate entries We were operating off the filtered view, so the logic would re-create paths all the time. Making it use the unfiltered list solves that.
Only applies to variables defined in the LVT, so no-op if no debug symbols are present
… matched contents
…rder of operations Even looking at the method it was referencing in an old commit, the comment didn't serve much as its not clear why it was all that important.
Not all constructors have the same number of arguments, so this isn't a good arbitrary check to have
Because frame generation can fail, its reasonable to wrap that portion and rethrow so that consumers *must* handle exceptions in some way.
…rror handling in calling context
…ng in dangling code
…ode fooling basic dangling-code analysis
…es to static final fields that are not explicitly set in the static initializer Some obfuscators don't initialize these fields and have things like opaque predicates operating off of the assumption they are initialized with default values like 0 or null.
…nd fixes up broken variable references
…s resulting from code removal
… remove try-catches in those ranges See the test case for an example. The opaque predicate is replaced with a goto during transformation. That makes the code for the try-catches dead, so when we remove the dead code we need to remove the try-catches because their label references are no longer in the method's instructions list.
… secondary resource
…lower systems On my Ryzen 7950X such tests never fail, even when repeated thousands of times. But on my i9-129000H they fail sporadically (~10% of iterations)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )