Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed MEGAQC_DEBUG to FLASK_DEBUG and tidied config profiles #68

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

ewels
Copy link
Member

@ewels ewels commented Oct 9, 2018

This is quite a simple change (it's all I can manage), but hopefully makes the different config profiles a little clearer.

  • Got rid of MEGAQC_DEBUG - it seems that FLASK_DEBUG has a bunch of built-in stuff that is difficult to get around, so may as well have just one env var instead of two
  • Improved logging a bit to try and make stuff clearer.

I did this because it annoyed me that most of the debug options weren't working with only MEGAQC_DEBUG set.

I had also hoped to hide the debug sidebar thing in the testing mode, but I can't figure this out and it's time to go to bed now.

@ewels ewels requested review from tsnowlan and Galithil October 9, 2018 22:18
Copy link
Collaborator

@tsnowlan tsnowlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ewels
Copy link
Member Author

ewels commented Oct 10, 2018

I'm thinking that it could be good to change the logic a little actually, so that you can still run in debug mode with a production server if you want...

@ewels
Copy link
Member Author

ewels commented Oct 10, 2018

Ok, I left the logic as it is. I guess if you want to run in debug mode you can still have the server settings in place so it should still work I think? 🤔

I did add one more change though - using megaqc.db as the sqlite database name instead of dev.db and test.db. Figured it made more sense to not switch database when running in different modes, and the new name is more intuitive.

@ewels
Copy link
Member Author

ewels commented Oct 10, 2018

ok cool, I think this is working as expected for me now 👍

@ewels ewels merged commit d2b3634 into master Oct 10, 2018
@ewels ewels deleted the FLASK_DEBUG branch October 10, 2018 10:05
@ewels
Copy link
Member Author

ewels commented Oct 10, 2018

I had also hoped to hide the debug sidebar thing in the testing mode, but I can't figure this out and it's time to go to bed now.

Today with a clear head and less whisky this is already working exactly as I hoped. Not sure why it wasn't doing what I was expecting last night... All good anyway! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants