-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker db decouple #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other feedback:
- We should add a docker-compose file that includes a Postgres database, so that users can run the entire stack automatically
- There should be a test in travis for the Docker image. Something simple like building it and then running it should be enough
"Flask==1.0.2", | ||
"future==0.16.0", | ||
"itsdangerous>=0.24", | ||
"Jinja2>=2.9.5", | ||
"markdown>=2.6.11", | ||
"numpy==1.14.3", | ||
"multiqc>=1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Agreed, this is something I was thinking about too
Also agreed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this @matthdsm! The Dockerfile is much much cleaner.. 👍 Nice work!
Hi,
I made some effort to decouple the db from the existing docker image.
I've also simplified the docker image and swapped out the base image, which should yield some perfomance bumps.
As far as I can see, everything seems to work, but I suppose some further testing is required.
TODO's
Cheers
M