Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker db decouple #89

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Docker db decouple #89

merged 3 commits into from
Oct 9, 2019

Conversation

matthdsm
Copy link
Contributor

Hi,

I made some effort to decouple the db from the existing docker image.
I've also simplified the docker image and swapped out the base image, which should yield some perfomance bumps.

As far as I can see, everything seems to work, but I suppose some further testing is required.
TODO's

  • create script for SQLalchemy migrations using alembic on startup

Cheers
M

Copy link
Collaborator

@multimeric multimeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other feedback:

  • We should add a docker-compose file that includes a Postgres database, so that users can run the entire stack automatically
  • There should be a test in travis for the Docker image. Something simple like building it and then running it should be enough

Dockerfile Outdated Show resolved Hide resolved
"Flask==1.0.2",
"future==0.16.0",
"itsdangerous>=0.24",
"Jinja2>=2.9.5",
"markdown>=2.6.11",
"numpy==1.14.3",
"multiqc>=1.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@matthdsm
Copy link
Contributor Author

matthdsm commented Aug 19, 2019

  • We should add a docker-compose file that includes a Postgres database, so that users can run the entire stack automatically

Agreed, this is something I was thinking about too

  • There should be a test in travis for the Docker image. Something simple like building it and then running it should be enough

Also agreed

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this @matthdsm! The Dockerfile is much much cleaner.. 👍 Nice work!

@ewels ewels merged commit c7435a8 into MultiQC:master Oct 9, 2019
@matthdsm matthdsm deleted the docker_db_decouple branch October 9, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants