fix(serf) disable error checking because of Serf bug

MushR00m · Aug 11, 2016 · 68b79bc · 68b79bc
1 parent 36a2a25
commit 68b79bc
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/kong/serf.lua b/kong/serf.lua
@@ -50,8 +50,10 @@ function Serf:join_node(address)
 end
 
 function Serf:leave()
-  local res, err = self:invoke_signal("leave")
-  if not res then return nil, err end
+  -- See https://github.com/hashicorp/serf/issues/400
+  -- Currently sometimes this returns an error, once that Serf issue has been
+  -- fixed we can check again for any errors returned by the following command.
+  self:invoke_signal("leave")
 
   local _, err = self.dao.nodes:delete {name = self.node_name}
   if err then return nil, tostring(err) end