Skip to content

Commit

Permalink
fix: wait for auth state before protocol version (#16815)
Browse files Browse the repository at this point in the history
## Description 

Describe the changes or additions included in this PR.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
  • Loading branch information
joyqvq authored Mar 22, 2024
1 parent 7d842a7 commit 843018f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion crates/sui-core/src/unit_tests/transaction_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,6 @@ async fn zklogin_test_cached_proof_wrong_key() {
) = setup_zklogin_network(|_| {}).await;

let res = client.handle_transaction(transfer_transaction).await;
info!("tktkres: {:?}", res);
assert!(res.is_ok());

/*
Expand Down
3 changes: 1 addition & 2 deletions crates/sui-e2e-tests/tests/zklogin_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,10 @@ async fn test_auth_state_creation() {
// Create test cluster without auth state object in genesis
let test_cluster = TestClusterBuilder::new()
.with_protocol_version(23.into())
.with_epoch_duration_ms(100)
.with_epoch_duration_ms(10000)
.with_default_jwks()
.build()
.await;

// Wait until we are in an epoch that has zklogin enabled, but the auth state object is not
// created yet.
test_cluster.wait_for_protocol_version(24.into()).await;
Expand Down

0 comments on commit 843018f

Please sign in to comment.