Skip to content

Commit

Permalink
Wrobertson/zidnexxx (#15233)
Browse files Browse the repository at this point in the history
## Description 

Describe the changes or additions included in this PR.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
  • Loading branch information
williamrobertson13 authored Dec 7, 2023
1 parent 6e5c1d3 commit d55db38
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/odd-lamps-behave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@mysten/dapp-kit': patch
---

Set a high z-index for the account dropdown so that it doesn't get hidden
4 changes: 4 additions & 0 deletions sdk/dapp-kit/src/components/AccountDropdownMenu.css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ export const connectedAccount = style({
gap: 8,
});

export const menuContainer = style({
zIndex: 999999999,
});

export const menuContent = style({
display: 'flex',
flexDirection: 'column',
Expand Down
2 changes: 1 addition & 1 deletion sdk/dapp-kit/src/components/AccountDropdownMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function AccountDropdownMenu({ currentAccount }: AccountDropdownMenuProps
</DropdownMenu.Trigger>
</StyleMarker>
<DropdownMenu.Portal>
<StyleMarker>
<StyleMarker className={styles.menuContainer}>
<DropdownMenu.Content className={styles.menuContent}>
{accounts.map((account) => (
<AccountDropdownMenuItem
Expand Down

3 comments on commit d55db38

@vercel
Copy link

@vercel vercel bot commented on d55db38 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on d55db38 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on d55db38 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.