Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kms] inline aws4fetch #20201

Merged
merged 2 commits into from
Dec 6, 2024
Merged

[kms] inline aws4fetch #20201

merged 2 commits into from
Dec 6, 2024

Conversation

hayes-mysten
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@hayes-mysten hayes-mysten requested a review from a team as a code owner November 7, 2024 18:33
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 7:52pm
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 7:52pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 7:52pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 7:52pm

@hayes-mysten hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env November 7, 2024 18:33 — with GitHub Actions Failure
@hayes-mysten hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env November 12, 2024 20:38 — with GitHub Actions Failure
@hayes-mysten hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env November 12, 2024 20:43 — with GitHub Actions Inactive
@hayes-mysten hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env November 12, 2024 20:47 — with GitHub Actions Inactive
@hayes-mysten hayes-mysten temporarily deployed to sui-typescript-aws-kms-test-env November 12, 2024 21:00 — with GitHub Actions Inactive
Copy link
Contributor

@williamrobertson13 williamrobertson13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@williamrobertson13 williamrobertson13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh btw, do we need to do manually pnpm deprecate for the @mysten/kms package?

@hayes-mysten
Copy link
Contributor Author

oh btw, do we need to do manually pnpm deprecate for the @mysten/kms package?

yes, we'll need to do that, probably @Jordan-Mysten (not sure who else has access to our npm org)

@hayes-mysten hayes-mysten merged commit e0885ca into main Dec 6, 2024
55 checks passed
@hayes-mysten hayes-mysten deleted the mh--inline-aws4fetch branch December 6, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants