change prettier-extension vscode setting name, tabSize to tabWidth #20407
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
|
Oof! Thank you for your contribution. That's definitely an oversight! |
klren0312
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
damirka
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the prettier-move in vscode setting,
tabWidthlabel name is error, it show thetabSize. So when I set thetabSize, format not workin the source, the extension only read the
tabWidthvalue, so need changetabWidthtotabWidthhttps://github.com/MystenLabs/sui/blob/main/external-crates/move/tooling/prettier-extension/src/extension.js#L110
Test plan
How did you test the new or updated feature?
yes
open the vscode settings, then find the menu that name is
prettierMoveyou can see the
Tab Size, set it to 2,then format the move file, it not work
but direct set the tabWidth, it work
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.