Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formatter] minor patches to tree-sitter and qol improvements #20532

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Dec 6, 2024

Description

  • mut is now better parsed as mut(param) instead of mut, param
  • abort allows no expression after
  • @1 address literals are now allowed
  • better handling of imm_ref and mut_ref, no more workarounds
  • qol improvements in block node printing
  • removes unused code
  • adds more tests for borrow_expression, index_expression and literal.

Test plan

Features tests, existing tests are not broken.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@damirka damirka requested review from tedks, awelc and tzakian December 6, 2024 08:59
@damirka damirka self-assigned this Dec 6, 2024
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Dec 6, 2024 8:59am
sui-kiosk ⬜️ Ignored (Inspect) Dec 6, 2024 8:59am
sui-typescript-docs ⬜️ Ignored (Inspect) Dec 6, 2024 8:59am

@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env December 6, 2024 08:59 — with GitHub Actions Inactive
@damirka damirka changed the title [formatter] minor patches to tree-sitter [formatter] minor patches to tree-sitter and qol improvements Dec 6, 2024
Copy link
Contributor

@manolisliolios manolisliolios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the simplification on mut/ref handling!

@damirka damirka merged commit 3e5cf29 into main Dec 10, 2024
56 checks passed
@damirka damirka deleted the ds/formatter-v2.1 branch December 10, 2024 09:36
@damirka
Copy link
Contributor Author

damirka commented Dec 10, 2024

Thank you @manolisliolios !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants