[Traffic Control] Fix blocked metric #20590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
williampsmith
force-pushed
the
william/fix-blocking-metrics
branch
from
bef2cce to
adec8b8
Compare
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
williampsmith
force-pushed
the
william/fix-blocking-metrics
branch
from
adec8b8 to
920519a
Compare
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
williampsmith
changed the title
mystenmark
approved these changes
Dec 11, 2024
johnjmartin
approved these changes
Dec 11, 2024
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
williampsmith
force-pushed
the
william/fix-blocking-metrics
branch
from
462c674 to
a6e170d
Compare
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
williampsmith
force-pushed
the
william/fix-blocking-metrics
branch
from
a6e170d to
a718749
Compare
williampsmith
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This metric was bumping in such a way that it would give the false impression that we are blocking requests when in dry run mode.
Test plan
👀
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.