Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: convert Client error to tonic::Status #20595

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Dec 11, 2024

Convert Client error type to be a tonic::Status. In addition, ensure
that if http headers (which are wrapped in a
tonic::metadata::MetadataMap) are received, that they are included in
either the response or the error Status so that callers can retrieve
header information even in the event of an error.

Introduce the ResponseExt trait to assist in reading well known headers
that are set by Sui Node services.
Convert Client error type to be a tonic::Status. In addition, ensure
that if http headers (which are wrapped in a
tonic::metadata::MetadataMap) are received, that they are included in
either the response or the error Status so that callers can retrieve
header information even in the event of an error.
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 3:09pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 3:09pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 3:09pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 3:09pm

@bmwill bmwill merged commit 0566223 into MystenLabs:main Dec 11, 2024
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants