-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Fix dev inspect in sui client ptb #20599
Merged
stefan-mysten
merged 1 commit into
MystenLabs:main
from
stefan-mysten:cli_dev_inspect_fix
Dec 11, 2024
Merged
[CLI] Fix dev inspect in sui client ptb #20599
stefan-mysten
merged 1 commit into
MystenLabs:main
from
stefan-mysten:cli_dev_inspect_fix
Dec 11, 2024
+24
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 11, 2024 18:58 — with
GitHub Actions
Inactive
tzakian
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit (that you can fix or not -- up to you) otherwise LGTM!
stefan-mysten
force-pushed
the
cli_dev_inspect_fix
branch
from
December 11, 2024 19:38
221dd20
to
ee5c877
Compare
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 11, 2024 19:39 — with
GitHub Actions
Inactive
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Dec 11, 2024
## Description This PR fixes the `sui client ptb --dev-inspect` command to correctly display the result of the dev inspect. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed `sui client ptb --dev-inspect` to correctly display the result of the dev inspect. - [ ] Rust SDK: - [ ] REST API:
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Dec 11, 2024
## Description This PR fixes the `sui client ptb --dev-inspect` command to correctly display the result of the dev inspect. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed `sui client ptb --dev-inspect` to correctly display the result of the dev inspect. - [ ] Rust SDK: - [ ] REST API:
stefan-mysten
added a commit
that referenced
this pull request
Dec 11, 2024
## Description This PR fixes the `sui client ptb --dev-inspect` command to correctly display the result of the dev inspect. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed `sui client ptb --dev-inspect` to correctly display the result of the dev inspect. - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
sui client ptb --dev-inspect
command to correctly display the result of the dev inspect.Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
sui client ptb --dev-inspect
to correctly display the result of the dev inspect.