Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Fix dev inspect in sui client ptb #20599

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

stefan-mysten
Copy link
Contributor

Description

This PR fixes the sui client ptb --dev-inspect command to correctly display the result of the dev inspect.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI: Fixed sui client ptb --dev-inspect to correctly display the result of the dev inspect.
  • Rust SDK:
  • REST API:

@stefan-mysten stefan-mysten requested review from damirka and a team December 11, 2024 18:57
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 7:40pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 7:40pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 7:40pm

Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit (that you can fix or not -- up to you) otherwise LGTM!

crates/sui/src/displays/dev_inspect.rs Outdated Show resolved Hide resolved
@stefan-mysten stefan-mysten temporarily deployed to sui-typescript-aws-kms-test-env December 11, 2024 19:39 — with GitHub Actions Inactive
@stefan-mysten stefan-mysten merged commit 7c61d70 into MystenLabs:main Dec 11, 2024
46 of 48 checks passed
@stefan-mysten stefan-mysten deleted the cli_dev_inspect_fix branch December 11, 2024 20:10
stefan-mysten added a commit to stefan-mysten/sui that referenced this pull request Dec 11, 2024
## Description 

This PR fixes the `sui client ptb --dev-inspect` command to correctly
display the result of the dev inspect.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [x] CLI: Fixed `sui client ptb --dev-inspect` to correctly display the
result of the dev inspect.
- [ ] Rust SDK:
- [ ] REST API:
stefan-mysten added a commit to stefan-mysten/sui that referenced this pull request Dec 11, 2024
## Description 

This PR fixes the `sui client ptb --dev-inspect` command to correctly
display the result of the dev inspect.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [x] CLI: Fixed `sui client ptb --dev-inspect` to correctly display the
result of the dev inspect.
- [ ] Rust SDK:
- [ ] REST API:
stefan-mysten added a commit that referenced this pull request Dec 11, 2024
## Description 

This PR fixes the `sui client ptb --dev-inspect` command to correctly
display the result of the dev inspect.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [x] CLI: Fixed `sui client ptb --dev-inspect` to correctly display the
result of the dev inspect.
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants