Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filemap to compiled package #20682

Conversation

jordanjennings-mysten
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:21pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 8:21pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 8:21pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 8:21pm

Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a step in the right direction, but the compiler has to already spit out the file map for the sake of errors. I think we should just thread that through

@tzakian
Copy link
Contributor

tzakian commented Dec 19, 2024

This change is threading it through I believe, but maybe I'm missing something here. (at least it is saving the MappedFiles from the compiler in the CompiledPackage which is what I think we want here?).

@jordanjennings-mysten jordanjennings-mysten merged commit f92d5a9 into MystenLabs:main Dec 19, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants