[quorum driver] Remove conflicting tx retry logic #20685
+78
−419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-koshy
requested review from
lxfind,
halfprice,
mystenmark and
jordanjennings-mysten
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
arun-koshy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic in quorum driver to retry conflicting transactions can end up in a situation where it is waiting for responses from all validators which can clog up QD and limit the throughput of our fullnodes. Additionally with
ValidatorTransactionFinalizercomponent added recently we no longer need to rely on QD to do this retry of conflicting tx. We still track the conflicting tx digest so that we can return a more useful error to the user in the case that those conflicting tx digests exist.