rpc-alt: e2e tests #20729
Open
rpc-alt: e2e tests #20729
+523
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Make various configs public, mainly so they can be used from the test config. ## Test plan CI
## Description This change adds a new custom command to the transactional test runner for calling a JSON-RPC query. This is supported by a new function on the `OffchainStateReader` trait to execute that JSON-RPC query, which is implemented trivially in the GraphQL transactional tests. ## Test plan CI
## Description Set-up transactional tests for Indexer-Alt and RPC-Alt ## Test plan Run the new transactional tests: ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests ```
## Description This used to be part of the interface neded by the transactional test runner to talk to the off chain state of the test cluster, but it is no longer in use (and isn't necessary for `sui-indexer-alt`), so it's easiest to get rid of it. ## Test plan ``` sui$ cargo nextest run \ -p sui-indexer-alt-e2e-tests \ -p sui-graphql-e2e-tests ```
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
reviewed
Dec 26, 2024
| // The test description is at the top because the JSON does not have explicit | ||
| // syntax for comments. | ||
|
|
||
| //# run-graphql |
There was a problem hiding this comment.
Should this be run-jsonrpc?
Also curious why it was possible to mix up? Should we error if it happens?
There was a problem hiding this comment.
No this is as intended. We do error if you try to run the wrong kind of query, and in fact this is the test for that (see the comments above this line).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for testing JSON-RPC methods in the transactional test runner, and set-up some tests for
sui-indexer-altandsui-indexer-alt-jsonrpc(testing the test framework itself, and the RGP method).Test plan
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.