rpc-alt: getOwnedObjects #21119
Open
rpc-alt: getOwnedObjects #21119
+2,273
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Rename `Cursor` to `JsonCursor`, and introduce a generic `Cursor` trait, so that we can introduce different cursor formats. This is in preparation for adding a `BcsCursor`, similar to what we have on the GraphQL side. ## Test plan CI (this is a refactoring)
## Description Basic support for getting an address's owned objects (without filtering by type). The performance of these queries could be improved by changing index order (such that the Object IDs are ordered similarly to cp_sequence_number), which will be done in a follow-up PR. of ## Test plan New E2E tests: ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests -- objects/query ``` Query performance was also validated by inspecting query plans on the production database (with and without a cursor present).
## Description Filter owned objects by packages. ## Test plan New E2E tests: ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests \ -- objects/query/by_package ```
## Description Filtering owned objects by their type's module. ## Test plan New E2E tests: ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests \ -- objects/query/by_module ```
## Description Filter owned objects by their type name (ignoring type parameters). ## Test plan New E2E tests: ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests \ -- objects/query/by_name ```
## Description Filter owned objects by it's type's type parameters. ## Test plan ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests \ -- objects/query/by_type_params ```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement querying objects by owner and type. Also introduce BCS-serialized cursors (to keep size down).
Test plan
New E2E tests:
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.