Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: on macOS fix dmg generation race condition #1024

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

jhoyt4
Copy link
Contributor

@jhoyt4 jhoyt4 commented Feb 5, 2025

On macOS 13, generation of the dmg distribution file intermidittenly
fails due to a "hdiutil: create failed - Resource busy" issue. Work
around this issue by creating a script that repeatedly attempts to
run hdiutil until success or 15 failures.

Thank you for contributing to MythTV!

Please review the checklist below to ensure that your contribution
to MythTV is ready for review by our developers.

It is helpful to regularly rebase your pull request to ensure changes
apply cleanly to the current MythTV development branch.

Thank you for contributing to MythTV!

Please review the checklist below to ensure that your contribution
to MythTV is ready for review by our developers.

It is helpful to regularly rebase your pull request to ensure changes
apply cleanly to the current MythTV development branch.

Checklist

  On macOS 13, generation of the dmg distribution file intermidittenly
  fails due to a "hdiutil: create failed - Resource busy" issue. Work
  around this issue by creating a script that repeatedly attempts to
  run hdiutil until success or 15 failures.

  Thank you for contributing to MythTV!

  Please review the checklist below to ensure that your contribution
  to MythTV is ready for review by our developers.

  It is helpful to regularly rebase your pull request to ensure changes
  apply cleanly to the current MythTV development branch.
@linuxdude42 linuxdude42 merged commit 5762763 into MythTV:master Feb 5, 2025
11 checks passed
@linuxdude42
Copy link
Contributor

I still got a failure on the macos 13 builder.

@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Feb 5, 2025

@linuxdude42 the failure looks to be unrelated.

The failure on the recent build was a runner/homebrew python3 install issue.

This PR should be unrelated as it only occurs if the code sign and distribution flags are manually set which are off by default in the CI chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants