Merge pull request RobotLocomotion#3490 from jwnimmer-tri/cpplint-ref…

…erences Push runtime/references suppressions to the leaves
NEU-ZJX · Sep 19, 2016 · 7829cd2 · 7829cd2
2 parents 4b8a5c6 + c399d5f
commit 7829cd2
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 3 deletions.
diff --git a/CPPLINT.cfg b/CPPLINT.cfg
@@ -35,6 +35,3 @@ filter=-readability/casting
 
 # TODO(#2273) Fix this.
 filter=-readability/namespace
-
-# TODO(#2274) Fix this.
-filter=-runtime/references
diff --git a/drake/common/CPPLINT.cfg b/drake/common/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/drake/examples/@VanDerPolCpp/CPPLINT.cfg b/drake/examples/@VanDerPolCpp/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/drake/examples/Acrobot/CPPLINT.cfg b/drake/examples/Acrobot/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/drake/examples/Pendulum/CPPLINT.cfg b/drake/examples/Pendulum/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/drake/examples/Quadrotor/CPPLINT.cfg b/drake/examples/Quadrotor/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/drake/math/CPPLINT.cfg b/drake/math/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/drake/solvers/CPPLINT.cfg b/drake/solvers/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/drake/systems/CPPLINT.cfg b/drake/systems/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/drake/util/CPPLINT.cfg b/drake/util/CPPLINT.cfg
@@ -0,0 +1,2 @@
+# TODO(#2274) Fix this.
+filter=-runtime/references
diff --git a/ros/drake_ros_systems/include/drake/ros/systems/ros_vehicle_system.h b/ros/drake_ros_systems/include/drake/ros/systems/ros_vehicle_system.h
@@ -19,6 +19,7 @@ namespace ros {
 namespace systems {
 
 bool decode(const ackermann_msgs::AckermannDriveStamped& msg,
+            // NOLINTNEXTLINE(runtime/references) due to LCMSystem.
             drake::automotive::DrivingCommand<double>& x) {
   x.set_steering_angle(msg.drive.steering_angle);
   if (msg.drive.speed > 0) {
@@ -119,6 +120,7 @@ class ROSAckermannCommandReceiverSystem {
 template <typename System>
 void run_ros_vehicle_sim(
     std::shared_ptr<System> sys, double t0, double tf,
+    // NOLINTNEXTLINE(runtime/references) False positive.
     const typename System::template StateVector<double>& x0,
     const SimulationOptions& options = SimulationOptions()) {
   auto ros_ackermann_input =
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# TODO(#2274) Fix this.
		filter=-runtime/references