Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve arabic translations and add modifications to script files #387

Merged
merged 5 commits into from
Dec 4, 2023
Merged

resolve arabic translations and add modifications to script files #387

merged 5 commits into from
Dec 4, 2023

Conversation

EugenSong
Copy link
Contributor

@EugenSong EugenSong commented Dec 2, 2023 •
edited
Loading

✅ I have read the contributing file

Summary

Resolves issue #383

Changelog

  • added a '/' to end of "app/screens/RecurringEmissions/translations" in generate-translation-files.js
  • included "ar" as part of usedLanguages in script files

@PierreBresson PierreBresson merged commit fb60988 into NMF-earth:main Dec 4, 2023
1 check passed
@PierreBresson
Copy link
Member

@EugenSong thanks for your contribution :)
fyi: I've pushed some fixes for it to work and improve the scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EugenSong @PierreBresson