019 optimise extraction #186
Merged
+1,524
−591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…points are sorted by x direction.
…large boundaries.
…he best option so parking for later.
…e is still a problem with z_dist and/or z_ind that mean the results aren't identical
…d values in arithmetic and unaccounted for in self.z_dist holding array.
…ake it easier to find later. Removed some mroe prints
…ss of tidying up extract.
…ted the plotting.
…tion to fix a bug with running the AMM15 example and get it ready to pull to master
jdha
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code now takes the boundary points and identifies discrete chunks based on breaks in the boundary from land, corners or long diagonals. This will reduce the memory required for reading in source data as strips are taken rather than the whole domain. This also fixes the issue with a large source domain needed for a boundary or regional model that wraps the east-west line.
I've written unit tests for the new functionality which pass. The code runs with the AMM15 test case and produces a reasonable solution. The 1-2-1 filter made the solution marginally different from the master at the corners so this has been turned off to have a consistent solution regardless of chunks. This closes #19.