Peak electricity outputs #1930

shorowit · 2025-02-14T00:34:42Z

Pull Request Description

Closes #1917.

Adds new net peak electricity outputs that include PV; total peak electricity outputs still exist.
Adds generator electricity produced to fuel/energy totals, in that it is treated as a device that primary offsets electricity consumption, not a device to export power to the grid. Net electricity values now differ from total electricity values solely because of PV.
Reintroduces battery charging/discharging in utility bill calculations and fuel/energy totals. (Was removed during Model EVs (using the E+ battery model) #1533.)

Checklist

Not all may apply:

Schematron validator (EPvalidator.xml) has been updated
Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

… code.

…-HPXML into peak_electricity

shorowit · 2025-02-14T21:24:48Z

HPXMLtoOpenStudio/resources/output.rb

+    # Create custom meters:
+    # - Total Electricity (Electricity:Facility plus EV charging, batteries, generators)
+    # - Net Electricity (above plus PV)
+    # - PV Electricity


Sets up custom meters that will be used downstream by both the ReportSimulationOutput (for total/net outputs) and ReportUtilityBills measures.

shorowit · 2025-02-14T21:26:28Z

ReportSimulationOutput/measure.rb

-    # Total/Net Electricity (Net includes, e.g., PV and generators)
-    outputs[:elec_prod_annual] = @end_uses.select { |k, eu| k[0] == FT::Elec && eu.is_negative }.map { |_k, eu| eu.annual_output.to_f }.sum(0.0) # Negative value
-    outputs[:elec_net_annual] = @fuels[FT::Elec].annual_output.to_f + outputs[:elec_prod_annual]
-    if args[:include_timeseries_fuel_consumptions]
-      prod_end_uses = @end_uses.select { |k, eu| k[0] == FT::Elec && eu.is_negative && eu.timeseries_output.size > 0 }.map { |_k, v| v.timeseries_output }
-      outputs[:elec_prod_timeseries] = prod_end_uses.transpose.map(&:sum)
-      outputs[:elec_prod_timeseries] = [0.0] * @timestamps.size if outputs[:elec_prod_timeseries].empty?
-      outputs[:elec_net_timeseries] = @fuels[FT::Elec].timeseries_output.zip(outputs[:elec_prod_timeseries]).map { |x, y| x + y }
-    end
-
-    # Total/Net Energy (Net includes, e.g., PV and generators)
+    # Total/Net Energy
    @totals[TE::Total].annual_output = 0.0
-    @fuels.each do |_fuel_type, fuel|
-      @totals[TE::Total].annual_output += fuel.annual_output
+    @totals[TE::Net].annual_output = 0.0
+    @fuels.each do |(fuel_type, total_or_net), fuel|
+      if fuel_type == FT::Elec
+        te_types = [total_or_net]
+      else
+        te_types = [TE::Total, TE::Net]
+      end
+
+      te_types.each do |te_type|
+        @totals[te_type].annual_output += fuel.annual_output
+      end
      next unless args[:include_timeseries_total_consumptions] && fuel.timeseries_output.sum != 0.0

-      @totals[TE::Total].timeseries_output = [0.0] * @timestamps.size if @totals[TE::Total].timeseries_output.empty?
-      unit_conv = UnitConversions.convert(1.0, fuel.timeseries_units, @totals[TE::Total].timeseries_units)
-      @totals[TE::Total].timeseries_output = @totals[TE::Total].timeseries_output.zip(fuel.timeseries_output).map { |x, y| x + y * unit_conv }
-    end
-    @totals[TE::Net].annual_output = @totals[TE::Total].annual_output + outputs[:elec_prod_annual]
-    if args[:include_timeseries_total_consumptions]
-      unit_conv = UnitConversions.convert(1.0, get_timeseries_units_from_fuel_type(FT::Elec), @totals[TE::Total].timeseries_units)
-      @totals[TE::Net].timeseries_output = @totals[TE::Total].timeseries_output.zip(outputs[:elec_prod_timeseries]).map { |x, y| x + y * unit_conv }
+      te_types.each do |te_type|
+        @totals[te_type].timeseries_output = [0.0] * @timestamps.size if @totals[te_type].timeseries_output.empty?
+        unit_conv = UnitConversions.convert(1.0, fuel.timeseries_units, @totals[te_type].timeseries_units)
+        @totals[te_type].timeseries_output = @totals[te_type].timeseries_output.zip(fuel.timeseries_output).map { |x, y| x + y * unit_conv }
+      end


Simplified this stuff. Now we only calculate total/net energy uses here (from fuel uses); nothing more is needed.

shorowit · 2025-02-14T21:47:54Z

ReportSimulationOutput/measure.rb

-    @fuels[FT::Elec] = Fuel.new(meters: ['Electricity:FacilityEVCharging'.upcase]) # Total Electricity; PV is subtracted later for Net Electricity output
-    @fuels[FT::Gas] = Fuel.new(meters: ["#{EPlus::FuelTypeNaturalGas}:Facility"])
-    @fuels[FT::Oil] = Fuel.new(meters: ["#{EPlus::FuelTypeOil}:Facility"])
-    @fuels[FT::Propane] = Fuel.new(meters: ["#{EPlus::FuelTypePropane}:Facility"])
-    @fuels[FT::WoodCord] = Fuel.new(meters: ["#{EPlus::FuelTypeWoodCord}:Facility"])
-    @fuels[FT::WoodPellets] = Fuel.new(meters: ["#{EPlus::FuelTypeWoodPellets}:Facility"])
-    @fuels[FT::Coal] = Fuel.new(meters: ["#{EPlus::FuelTypeCoal}:Facility"])
-
-    @fuels.each do |fuel_type, fuel|
-      fuel.name = "Fuel Use: #{fuel_type}: Total"
+    @fuels[[FT::Elec, TE::Total]] = Fuel.new(meter: 'Electricity:Total'.upcase)
+    @fuels[[FT::Elec, TE::Net]] = Fuel.new(meter: 'Electricity:Net'.upcase)
+    @fuels[[FT::Gas, TE::Total]] = Fuel.new(meter: "#{EPlus::FuelTypeNaturalGas}:Facility")
+    @fuels[[FT::Oil, TE::Total]] = Fuel.new(meter: "#{EPlus::FuelTypeOil}:Facility")
+    @fuels[[FT::Propane, TE::Total]] = Fuel.new(meter: "#{EPlus::FuelTypePropane}:Facility")
+    @fuels[[FT::WoodCord, TE::Total]] = Fuel.new(meter: "#{EPlus::FuelTypeWoodCord}:Facility")
+    @fuels[[FT::WoodPellets, TE::Total]] = Fuel.new(meter: "#{EPlus::FuelTypeWoodPellets}:Facility")
+    @fuels[[FT::Coal, TE::Total]] = Fuel.new(meter: "#{EPlus::FuelTypeCoal}:Facility")


Explicitly sets up net/total versions for electricity with corresponding meters. No longer calculates the net version in the measure by combining outputs.

shorowit · 2025-02-14T21:48:17Z

ReportSimulationOutput/measure.rb

-        fuel.meters = []
+        fuel.meter = nil


No longer needs to be an array. Everything uses a built-in meter or a custom meter.

shorowit · 2025-02-14T21:48:31Z

ReportSimulationOutput/measure.rb

+    @peak_fuels[[FT::Elec, TE::Total, PFT::Winter]] = PeakFuel.new(report: 'Peak Electricity Total', meter: 'Electricity:Total')
+    @peak_fuels[[FT::Elec, TE::Total, PFT::Summer]] = PeakFuel.new(report: 'Peak Electricity Total', meter: 'Electricity:Total')
+    @peak_fuels[[FT::Elec, TE::Total, PFT::Annual]] = PeakFuel.new(report: 'Peak Electricity Total', meter: 'Electricity:Total')
+    @peak_fuels[[FT::Elec, TE::Net, PFT::Winter]] = PeakFuel.new(report: 'Peak Electricity Net', meter: 'Electricity:Net')
+    @peak_fuels[[FT::Elec, TE::Net, PFT::Summer]] = PeakFuel.new(report: 'Peak Electricity Net', meter: 'Electricity:Net')
+    @peak_fuels[[FT::Elec, TE::Net, PFT::Annual]] = PeakFuel.new(report: 'Peak Electricity Net', meter: 'Electricity:Net')


Adds net versions of peak electricity outputs.

shorowit · 2025-02-14T21:54:24Z

workflow/tests/base_results/results_simulations_bills.csv

-base-vehicle-ev-charger-undercharged.xml,1804.39,144.0,1241.69,0.0,1385.69,144.0,274.7,418.7,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
-base-vehicle-ev-charger.xml,2083.24,144.0,1520.54,0.0,1664.54,144.0,274.7,418.7,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-vehicle-ev-charger-scheduled.xml,2069.26,144.0,1506.56,0.0,1650.56,144.0,274.7,418.7,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-vehicle-ev-charger-undercharged.xml,1814.34,144.0,1251.64,0.0,1395.64,144.0,274.7,418.7,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0


I'm not entirely sure what was wrong before, but I verified this number is 100% correct. If you take this $ amount and divide it by the total building kWh, you get the exact $/kWh value as shown in in.xml as the electric utility rate. Before it was slightly off.

shorowit · 2025-02-14T21:55:13Z

workflow/tests/base_results/results_simulations_energy.csv

-base-battery-scheduled-power-outage.xml,57.721,57.721,33.884,33.884,23.837,0.0,0.0,0.0,0.0,0.0,0.0,0.591,0.0,0.0,3.406,0.484,8.4,0.0,0.0,4.2,0.0,0.311,0.0,0.0,0.0,0.0,1.882,0.0,0.0,0.292,0.335,1.386,1.401,0.0,1.94,7.686,0.0,0.0,0.0,0.0,0.0,0.0,0.0,1.587,0.0,23.837,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
-base-battery-scheduled.xml,61.33,61.33,37.514,37.514,23.816,0.0,0.0,0.0,0.0,0.0,0.0,0.591,0.0,0.0,4.398,0.662,9.013,0.0,0.0,4.507,0.0,0.334,0.0,0.0,0.0,0.0,2.072,0.0,0.0,0.319,0.365,1.513,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,1.735,0.0,23.816,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-battery-scheduled-power-outage.xml,57.741,57.741,33.903,33.903,23.837,0.0,0.0,0.0,0.0,0.0,0.0,0.591,0.0,0.0,3.406,0.484,8.4,0.0,0.0,4.2,0.0,0.311,0.0,0.0,0.0,0.0,1.882,0.0,0.0,0.292,0.335,1.386,1.401,0.0,1.94,7.686,0.0,0.0,0.0,0.0,0.0,0.0,0.0,1.587,0.0,23.837,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-battery-scheduled.xml,61.352,61.352,37.536,37.536,23.816,0.0,0.0,0.0,0.0,0.0,0.0,0.591,0.0,0.0,4.398,0.662,9.013,0.0,0.0,4.507,0.0,0.334,0.0,0.0,0.0,0.0,2.072,0.0,0.0,0.319,0.365,1.513,1.529,0.0,2.116,8.384,0.0,0.0,0.0,0.0,0.0,0.0,0.0,1.735,0.0,23.816,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0


Battery charging/discharging is being accounted for again. (Was removed in the EV PR.)

shorowit · 2025-02-14T21:55:35Z

workflow/tests/base_results/results_simulations_energy.csv

-base-bldgtype-mf-unit-shared-generator.xml,41.001,34.177,25.935,19.111,0.899,0.0,14.167,0.0,0.0,0.0,0.0,0.01,0.0,0.0,2.931,0.415,9.526,0.0,0.0,2.025,0.0,0.206,0.0,0.0,0.0,0.0,2.186,0.0,0.0,0.319,0.365,1.513,1.529,0.0,2.116,2.795,0.0,0.0,0.0,0.0,0.0,0.0,-6.824,0.0,0.0,0.899,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,14.167,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
+base-bldgtype-mf-unit-shared-generator.xml,34.177,34.177,19.111,19.111,0.899,0.0,14.167,0.0,0.0,0.0,0.0,0.01,0.0,0.0,2.931,0.415,9.526,0.0,0.0,2.025,0.0,0.206,0.0,0.0,0.0,0.0,2.186,0.0,0.0,0.319,0.365,1.513,1.529,0.0,2.116,2.795,0.0,0.0,0.0,0.0,0.0,0.0,-6.824,0.0,0.0,0.899,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,14.167,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0


Generator electricity production now included in Energy/Fuel Totals.

shorowit · 2025-02-14T21:56:20Z

workflow/tests/base_results/results_simulations_misc.csv

+HPXML,Unmet Hours: Heating (hr),Unmet Hours: Cooling (hr),Unmet Hours: EV Driving (hr),Hot Water: Clothes Washer (gal),Hot Water: Dishwasher (gal),Hot Water: Fixtures (gal),Hot Water: Distribution Waste (gal),Peak Electricity: Winter Total (W),Peak Electricity: Summer Total (W),Peak Electricity: Annual Total (W),Peak Electricity: Winter Net (W),Peak Electricity: Summer Net (W),Peak Electricity: Annual Net (W),Peak Load: Heating: Delivered (kBtu/hr),Peak Load: Cooling: Delivered (kBtu/hr),Resilience: Battery (hr)
+base-appliances-coal.xml,0.0,0.0,0.0,1354.7,998.0,11171.6,2563.5,1984.0,3545.9,3545.9,1984.0,3545.9,3545.9,23.636,19.047,0.0


New net peak electricity outputs.

shorowit · 2025-02-14T21:57:28Z

workflow/tests/base_results/results_simulations_misc.csv

+base-atticroof-unvented-insulated-roof.xml,0.0,0.0,0.0,1354.7,998.0,11171.6,2563.5,2069.5,3413.5,3413.5,2069.5,3413.5,3413.5,20.537,14.701,0.0
+base-atticroof-vented.xml,0.0,0.0,0.0,1354.7,998.0,11171.5,2563.5,2083.8,3399.5,3399.5,2083.8,3399.5,3399.5,23.824,16.752,0.0
+base-battery-scheduled-power-outage.xml,0.0,5.0,0.0,1241.4,914.9,10291.7,2361.6,7802.3,8148.5,8148.5,7802.3,8148.5,8148.5,23.712,21.153,1.337
+base-battery-scheduled.xml,0.0,0.0,0.0,1354.7,998.0,11171.6,2563.5,7802.1,8197.2,8197.2,7802.1,8197.2,8197.2,23.71,18.744,1.438


Battery charging/discharging is being accounted for again. (Was removed in the EV PR.)

@joseph-robertson The reason the increase is ~4.5 kW instead of the battery's rated power of ~6 kW is because the scheduled charging is not coincident with the building peak. (In the chart below, orange is battery charging/discharging, blue is building consumption, and the results are stacked.)

Makes sense. Only if the scheduled charging was coincident with building peak would the increases shown in results_simulation_misc.csv be equal to the battery's rated power. (Does this mean rated power input/charge is assumed to be equal to rated power output/discharge? Looking at example IDF and this, it appears this is the case -- should the docs note anything about this?)

Doesn't feel necessary to me to document that.

…-HPXML into peak_electricity

…o peak_electricity # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportSimulationOutput/measure.xml

ReportSimulationOutput/measure.rb

ReportUtilityBills/measure.rb

Changelog.md

…run successfully.

Changelog.md

shorowit added 2 commits February 13, 2025 16:41

Use custom meters for total electricity and net electricity, simplify…

dd1d6bd

… code.

Simplify ReportUtilityBills too.

692477b

shorowit self-assigned this Feb 14, 2025

shorowit and others added 7 commits February 13, 2025 18:03

Bugfix.

f11c534

Bugfixes.

2071417

Revert debug

3de1e19

Bugfix.

53924f9

Bugfix.

c578102

Latest results.

46b801f

Simplify outputs/meters.

3cab4aa

shorowit mentioned this pull request Feb 14, 2025

EV follow-up #1929

Open

7 tasks

GitHub Action and others added 5 commits February 14, 2025 16:36

Latest results.

9885ad8

Add net peak electricity outputs.

4736276

Merge branch 'peak_electricity' of https://github.com/NREL/OpenStudio…

8307127

…-HPXML into peak_electricity

Latest results.

85d0402

Update changelog [ci skip]

24f728e

shorowit marked this pull request as ready for review February 14, 2025 18:51

shorowit added 2 commits February 14, 2025 14:20

Clean up changelog. [ci skip]

f571428

Code simplification. This no longer needs to be an array.

603a1ad

shorowit commented Feb 14, 2025

View reviewed changes

shorowit requested a review from joseph-robertson February 14, 2025 21:58

shorowit and others added 7 commits February 17, 2025 16:59

Changes based on review comments. And a little cleanup.

8df6436

Latest results.

cc5a9f2

Revert this, it was needed.

cf13591

Merge branch 'peak_electricity' of https://github.com/NREL/OpenStudio…

e1e98cd

…-HPXML into peak_electricity

Latest results.

1ccdbe9

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

fabdb1a

…o peak_electricity # Conflicts: # HPXMLtoOpenStudio/measure.xml # ReportSimulationOutput/measure.xml

Add total vs net error checking.

cac7620

joseph-robertson reviewed Feb 18, 2025

View reviewed changes

ReportSimulationOutput/measure.rb Outdated Show resolved Hide resolved

ReportUtilityBills/measure.rb Show resolved Hide resolved

Changelog.md Show resolved Hide resolved

Replace error-check with unit tests. Allow PV w/ MaxPowerOutput=0 to …

140dfe3

…run successfully.

shorowit commented Feb 18, 2025

View reviewed changes

Changelog.md Show resolved Hide resolved

Update changelog [ci skip]

4375a85

joseph-robertson self-requested a review February 18, 2025 19:32

joseph-robertson approved these changes Feb 18, 2025

View reviewed changes

shorowit merged commit 663f682 into master Feb 18, 2025

shorowit deleted the peak_electricity branch February 18, 2025 20:28

joseph-robertson mentioned this pull request Feb 18, 2025

Latest OS-HPXML NREL/resstock#1347

Merged

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Peak electricity outputs #1930

Peak electricity outputs #1930

shorowit commented Feb 14, 2025 •

edited

Loading

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 14, 2025

shorowit Feb 17, 2025

joseph-robertson Feb 18, 2025

shorowit Feb 18, 2025

		base-bldgtype-mf-unit-shared-generator.xml,41.001,34.177,25.935,19.111,0.899,0.0,14.167,0.0,0.0,0.0,0.0,0.01,0.0,0.0,2.931,0.415,9.526,0.0,0.0,2.025,0.0,0.206,0.0,0.0,0.0,0.0,2.186,0.0,0.0,0.319,0.365,1.513,1.529,0.0,2.116,2.795,0.0,0.0,0.0,0.0,0.0,0.0,-6.824,0.0,0.0,0.899,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,14.167,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0
		base-bldgtype-mf-unit-shared-generator.xml,34.177,34.177,19.111,19.111,0.899,0.0,14.167,0.0,0.0,0.0,0.0,0.01,0.0,0.0,2.931,0.415,9.526,0.0,0.0,2.025,0.0,0.206,0.0,0.0,0.0,0.0,2.186,0.0,0.0,0.319,0.365,1.513,1.529,0.0,2.116,2.795,0.0,0.0,0.0,0.0,0.0,0.0,-6.824,0.0,0.0,0.899,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,14.167,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0

		HPXML,Unmet Hours: Heating (hr),Unmet Hours: Cooling (hr),Unmet Hours: EV Driving (hr),Hot Water: Clothes Washer (gal),Hot Water: Dishwasher (gal),Hot Water: Fixtures (gal),Hot Water: Distribution Waste (gal),Peak Electricity: Winter Total (W),Peak Electricity: Summer Total (W),Peak Electricity: Annual Total (W),Peak Electricity: Winter Net (W),Peak Electricity: Summer Net (W),Peak Electricity: Annual Net (W),Peak Load: Heating: Delivered (kBtu/hr),Peak Load: Cooling: Delivered (kBtu/hr),Resilience: Battery (hr)
		base-appliances-coal.xml,0.0,0.0,0.0,1354.7,998.0,11171.6,2563.5,1984.0,3545.9,3545.9,1984.0,3545.9,3545.9,23.636,19.047,0.0

Peak electricity outputs #1930

Peak electricity outputs #1930

Conversation

shorowit commented Feb 14, 2025 • edited Loading

Pull Request Description

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shorowit commented Feb 14, 2025 •

edited

Loading